From: Samuel Thibault <samuel.thibault@gnu.org>
To: Doug Evans <dje@google.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH v2 2/2] net: Add -ipv6-hostfwd option, ipv6_hostfwd_add/remove commands
Date: Wed, 3 Feb 2021 23:20:53 +0100 [thread overview]
Message-ID: <20210203222053.htsym7musxnqpc5n@begin> (raw)
In-Reply-To: <20210203213729.1940893-3-dje@google.com>
Doug Evans, le mer. 03 févr. 2021 13:37:29 -0800, a ecrit:
> @@ -1392,6 +1392,34 @@ SRST
> Remove host-to-guest TCP or UDP redirection.
> ERST
>
> +#ifdef CONFIG_SLIRP
> + {
> + .name = "ipv6_hostfwd_add",
> + .args_type = "arg1:s,arg2:s?",
> + .params = "[netdev_id] [tcp|udp]:[hostaddr6]:hostport-[guestaddr6]:guestport",
Perhaps explicit that the IPv6 address should be enclosed with [] ?
> + /* Ignore the part between the ']' and addr_sep. */
> + if (get_str_sep(buf, sizeof(buf), &p, addr_sep) < 0) {
Mmm, I would say that we do not want to just ignore it, and rather make
sure that it is empty, so that we can possibly make extensions later
without breaking existing misuse.
Samuel
next prev parent reply other threads:[~2021-02-03 22:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 21:37 [PATCH v2 0/2] Add support for ipv6 host forwarding dje--- via
2021-02-03 21:37 ` [PATCH v2 1/2] net/slirp.c: Refactor address parsing dje--- via
2021-02-03 21:39 ` Doug Evans
2021-02-03 22:15 ` Samuel Thibault
2021-02-03 22:31 ` Doug Evans
2021-02-08 11:09 ` Philippe Mathieu-Daudé
2021-02-08 18:59 ` Doug Evans
2021-02-28 22:44 ` Samuel Thibault
2021-02-03 21:37 ` [PATCH v2 2/2] net: Add -ipv6-hostfwd option, ipv6_hostfwd_add/remove commands dje--- via
2021-02-03 22:20 ` Samuel Thibault [this message]
2021-02-03 22:29 ` Doug Evans
2021-02-04 9:57 ` Daniel P. Berrangé
2021-02-03 21:45 ` [PATCH v2 0/2] Add support for ipv6 host forwarding no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210203222053.htsym7musxnqpc5n@begin \
--to=samuel.thibault@gnu.org \
--cc=dje@google.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).