* [PATCH] qemu-storage-daemon: Enable object-add
@ 2021-02-04 7:21 Kevin Wolf
2021-02-04 10:04 ` Daniel P. Berrangé
0 siblings, 1 reply; 2+ messages in thread
From: Kevin Wolf @ 2021-02-04 7:21 UTC (permalink / raw)
To: qemu-block; +Cc: kwolf, qemu-devel
As we don't have a fully QAPIfied version of object-add yet and it still
has 'gen': false in the schema, it needs to be registered explicitly in
init_qmp_commands() to be available for users.
Fixes: 2af282ec51a27116d0402cab237b8970800f870c
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
storage-daemon/qemu-storage-daemon.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/storage-daemon/qemu-storage-daemon.c b/storage-daemon/qemu-storage-daemon.c
index d8d172cc60..9021a46b3a 100644
--- a/storage-daemon/qemu-storage-daemon.c
+++ b/storage-daemon/qemu-storage-daemon.c
@@ -144,6 +144,8 @@ static void init_qmp_commands(void)
qmp_init_marshal(&qmp_commands);
qmp_register_command(&qmp_commands, "query-qmp-schema",
qmp_query_qmp_schema, QCO_ALLOW_PRECONFIG);
+ qmp_register_command(&qmp_commands, "object-add", qmp_object_add,
+ QCO_NO_OPTIONS);
QTAILQ_INIT(&qmp_cap_negotiation_commands);
qmp_register_command(&qmp_cap_negotiation_commands, "qmp_capabilities",
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] qemu-storage-daemon: Enable object-add
2021-02-04 7:21 [PATCH] qemu-storage-daemon: Enable object-add Kevin Wolf
@ 2021-02-04 10:04 ` Daniel P. Berrangé
0 siblings, 0 replies; 2+ messages in thread
From: Daniel P. Berrangé @ 2021-02-04 10:04 UTC (permalink / raw)
To: Kevin Wolf; +Cc: qemu-devel, qemu-block
On Thu, Feb 04, 2021 at 08:21:37AM +0100, Kevin Wolf wrote:
> As we don't have a fully QAPIfied version of object-add yet and it still
> has 'gen': false in the schema, it needs to be registered explicitly in
> init_qmp_commands() to be available for users.
>
> Fixes: 2af282ec51a27116d0402cab237b8970800f870c
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> storage-daemon/qemu-storage-daemon.c | 2 ++
> 1 file changed, 2 insertions(+)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-04 10:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-04 7:21 [PATCH] qemu-storage-daemon: Enable object-add Kevin Wolf
2021-02-04 10:04 ` Daniel P. Berrangé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).