From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6ABD0C433DB for ; Thu, 4 Feb 2021 09:31:34 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EC35464F48 for ; Thu, 4 Feb 2021 09:31:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EC35464F48 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:36346 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l7az6-0003nK-S2 for qemu-devel@archiver.kernel.org; Thu, 04 Feb 2021 04:31:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43670) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l7axC-0003L4-3P for qemu-devel@nongnu.org; Thu, 04 Feb 2021 04:29:34 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:38003) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l7axA-0003eK-6N for qemu-devel@nongnu.org; Thu, 04 Feb 2021 04:29:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612430970; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zbeA00z3jpyrPwgFD4Bkz4KyOEqTGkhoefXuTet+8uE=; b=JmODBNEuhwGHFC11DevYhXGakgds3KWflF1N4kf2r/enBIu1Qtd0KdLXGe0DplGZFsF/Di LODtH56rJMvilicf6S0II8379CCTZsJL5kGZCgt0bxA6M7YzUOX+cqUwDLKvqeEwGIyl0N vkkxbeS6g9XYz+tJmnemzGFcxuEC8OA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-158-znmYjSbfNWe-em0_DDiqqA-1; Thu, 04 Feb 2021 04:29:26 -0500 X-MC-Unique: znmYjSbfNWe-em0_DDiqqA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 95405107B464; Thu, 4 Feb 2021 09:29:17 +0000 (UTC) Received: from localhost (ovpn-114-98.ams2.redhat.com [10.36.114.98]) by smtp.corp.redhat.com (Postfix) with ESMTP id 38CA65D9C0; Thu, 4 Feb 2021 09:29:17 +0000 (UTC) Date: Thu, 4 Feb 2021 09:29:16 +0000 From: "Richard W.M. Jones" To: David Hildenbrand Subject: Re: [PULL 11/24] tcg/optimize: Use tcg_constant_internal with constant folding Message-ID: <20210204092916.GS27779@redhat.com> References: <28457ae1-7e9b-4428-cb10-3b79ebeac8d0@linaro.org> <19D304C1-6401-4D16-AB54-DD19C978D04D@redhat.com> <20210204090351.GN30079@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210204090351.GN30079@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=rjones@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=63.128.21.124; envelope-from=rjones@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -32 X-Spam_score: -3.3 X-Spam_bar: --- X-Spam_report: (-3.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.539, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" > > commit 8f17a975e60b773d7c366a81c0d9bbe304f30859 > > Author: Richard Henderson > > Date: Mon Mar 30 19:52:02 2020 -0700 > > > > tcg/optimize: Adjust TempOptInfo allocation > > > > The image boots just fine on s390x/TCG as well. > > Let me try this in a minute on my original test machine. I got the wrong end of the stick as David pointed out in the other email. However I did test things again this morning (all on s390 host), and current head (1ed9228f63ea4b) fails same as before ("mount" command fails). Also I downloaded: https://dl.fedoraproject.org/pub/fedora-secondary/releases/33/Cloud/s390x/images/Fedora-Cloud-Base-33-1.2.s390x.qcow2 and booted it on 1ed9228f63ea4b using this command: $ ~/d/qemu/build/s390x-softmmu/qemu-system-s390x -machine accel=tcg -m 2048 -drive file=Fedora-Cloud-Base-33-1.2.s390x.qcow2,format=qcow2,if=virtio -serial stdio Lots of core dumps inside the guest, same as David saw. I then reset qemu back to 8f17a975e60b773d ("tcg/optimize: Adjust TempOptInfo allocation"), rebuilt qemu, tested the same command and cloud image, and that booted up much happier with no failures or core dumps. Isn't it kind of weird that this would only affect an s390 host? I don't understand why the host would make a difference if we're doing TCG. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports Linux and Windows. http://people.redhat.com/~rjones/virt-df/