From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Joe Komlodi" <komlodi@xilinx.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH 2/2] target/cris: Let cris_mmu_translate() use MMUAccessType access_type
Date: Thu, 4 Feb 2021 15:33:37 +0100 [thread overview]
Message-ID: <20210204143337.GG477672@toto> (raw)
In-Reply-To: <08f1efab-91c8-a7e7-98ee-6d73d5ccfad8@linaro.org>
On Wed, Feb 03, 2021 at 04:46:28PM -1000, Richard Henderson wrote:
> On 1/27/21 2:32 PM, Philippe Mathieu-Daudé wrote:
> > All callers of cris_mmu_translate() provide a MMUAccessType
> > type. Let the prototype use it as argument, as it is stricter
> > than an integer. We can remove the documentation as enum
> > names are self explicit.
> >
> > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> > ---
> > target/cris/mmu.h | 2 +-
> > target/cris/mmu.c | 24 ++++++++++++------------
> > 2 files changed, 13 insertions(+), 13 deletions(-)
>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
prev parent reply other threads:[~2021-02-04 14:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 0:32 [PATCH 0/2] target/cris: Pass MMUAccessType to cris_mmu_translate() Philippe Mathieu-Daudé
2021-01-28 0:32 ` [PATCH 1/2] target/cris: Use MMUAccessType enum type when possible Philippe Mathieu-Daudé
2021-02-04 2:45 ` Richard Henderson
2021-02-04 14:33 ` Edgar E. Iglesias
2021-01-28 0:32 ` [PATCH 2/2] target/cris: Let cris_mmu_translate() use MMUAccessType access_type Philippe Mathieu-Daudé
2021-02-04 2:46 ` Richard Henderson
2021-02-04 14:33 ` Edgar E. Iglesias [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210204143337.GG477672@toto \
--to=edgar.iglesias@gmail.com \
--cc=f4bug@amsat.org \
--cc=komlodi@xilinx.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).