From: "Daniel P. Berrangé" <berrange@redhat.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-block@nongnu.org, Juan Quintela <quintela@redhat.com>,
John Snow <jsnow@redhat.com>,
qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>,
Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>,
Paolo Bonzini <pbonzini@redhat.com>,
Max Reitz <mreitz@redhat.com>
Subject: Re: [PATCH v11 12/12] migration: introduce snapshot-{save, load, delete} QMP commands
Date: Thu, 4 Feb 2021 15:38:22 +0000 [thread overview]
Message-ID: <20210204153822.GS549438@redhat.com> (raw)
In-Reply-To: <20210204153433.GG24147@work-vm>
On Thu, Feb 04, 2021 at 03:34:33PM +0000, Dr. David Alan Gilbert wrote:
> This is (intermittently?) failing for me because of ordering issues:
>
> --- /home/dgilbert/git/migpull/tests/qemu-iotests/tests/internal-snapshots-qapi.out
> +++ internal-snapshots-qapi.out.bad
> @@ -344,8 +344,8 @@
> "vmstate": "diskfmt0",
> "devices": ["diskfmt0"]}}
> {"return": {}}
> +qemu-system-x86_64: Unknown savevm section or instance '0000:00:02.0/virtio-rng' 0. Make sure that your current VM setup matches your saved VM setup, including any hotplugged devices
> {"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "created", "id": "load-err-stderr"}}
> -qemu-system-x86_64: Unknown savevm section or instance '0000:00:02.0/virtio-rng' 0. Make sure that your current VM setup matches your saved VM setup, including any hotplugged devices
> {"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "running", "id": "load-err-stderr"}}
> {"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "STOP"}
> {"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "aborting", "id": "load-err-stderr"}}
> Not run: 259
> Failures: internal-snapshots-qapi
> Failed 1 of 124 iotests
>
> I'll disable the test for now.
Ok. I'm working on a patch series to make migration code use "Error **errp"
that ought to fix this properly.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2021-02-04 15:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 12:48 [PATCH v11 00/12] migration: bring improved savevm/loadvm/delvm to QMP Daniel P. Berrangé
2021-02-04 12:48 ` [PATCH v11 01/12] block: push error reporting into bdrv_all_*_snapshot functions Daniel P. Berrangé
2021-02-04 12:48 ` [PATCH v11 02/12] migration: Make save_snapshot() return bool, not 0/-1 Daniel P. Berrangé
2021-02-04 12:48 ` [PATCH v11 03/12] migration: stop returning errno from load_snapshot() Daniel P. Berrangé
2021-02-04 12:48 ` [PATCH v11 04/12] block: add ability to specify list of blockdevs during snapshot Daniel P. Berrangé
2021-02-04 12:48 ` [PATCH v11 05/12] block: allow specifying name of block device for vmstate storage Daniel P. Berrangé
2021-02-04 12:48 ` [PATCH v11 06/12] block: rename and alter bdrv_all_find_snapshot semantics Daniel P. Berrangé
2021-02-04 12:48 ` [PATCH v11 07/12] migration: control whether snapshots are ovewritten Daniel P. Berrangé
2021-02-04 12:48 ` [PATCH v11 08/12] migration: wire up support for snapshot device selection Daniel P. Berrangé
2021-02-04 12:48 ` [PATCH v11 09/12] migration: introduce a delete_snapshot wrapper Daniel P. Berrangé
2021-02-04 12:48 ` [PATCH v11 10/12] iotests: add support for capturing and matching QMP events Daniel P. Berrangé
2021-02-04 12:48 ` [PATCH v11 11/12] iotests: fix loading of common.config from tests/ subdir Daniel P. Berrangé
2021-02-04 12:48 ` [PATCH v11 12/12] migration: introduce snapshot-{save, load, delete} QMP commands Daniel P. Berrangé
2021-02-04 15:34 ` Dr. David Alan Gilbert
2021-02-04 15:38 ` Daniel P. Berrangé [this message]
2021-02-04 15:40 ` [PATCH v11 12/12] migration: introduce snapshot-{save,load,delete} " Eric Blake
2021-02-16 18:58 ` John Snow
2021-02-04 15:17 ` [PATCH v11 00/12] migration: bring improved savevm/loadvm/delvm to QMP Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210204153822.GS549438@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pavel.dovgaluk@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).