From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48B96C433DB for ; Thu, 4 Feb 2021 17:51:52 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A307364E0D for ; Thu, 4 Feb 2021 17:51:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A307364E0D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41340 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l7inG-0007do-D6 for qemu-devel@archiver.kernel.org; Thu, 04 Feb 2021 12:51:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43198) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l7hnv-00021H-Ew for qemu-devel@nongnu.org; Thu, 04 Feb 2021 11:48:27 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:35852) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l7hnt-0000Eu-MP for qemu-devel@nongnu.org; Thu, 04 Feb 2021 11:48:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612457304; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JQS6c1Ff7oRNT4E7aZGLoGNlz9zWh3TxNedGRxLSArQ=; b=MQPmQrISWgViprtyDGn0cZwpK9V5sP4pfw0OjMR4IuIwbXCmBoT6EudzIz1EIvUhDFgUzO 6JPwYbrsCUL+jiTj0M9xINOhZymA0DQ/9Pm9Aqzj6d/l6QoxOMwMUP34aa4/F2qWQmDbXo Nygq42QwTDScbdsHmSQylCM94YKVCig= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-215-NvQ8Ts7ZMVKBYtrjQoCilw-1; Thu, 04 Feb 2021 11:48:18 -0500 X-MC-Unique: NvQ8Ts7ZMVKBYtrjQoCilw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8985E8030B4; Thu, 4 Feb 2021 16:48:17 +0000 (UTC) Received: from localhost (ovpn-114-98.ams2.redhat.com [10.36.114.98]) by smtp.corp.redhat.com (Postfix) with ESMTP id 30E5219708; Thu, 4 Feb 2021 16:48:14 +0000 (UTC) Date: Thu, 4 Feb 2021 16:48:13 +0000 From: "Richard W.M. Jones" To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Subject: Re: [PULL 11/24] tcg/optimize: Use tcg_constant_internal with constant folding Message-ID: <20210204164813.GU30079@redhat.com> References: <28457ae1-7e9b-4428-cb10-3b79ebeac8d0@linaro.org> <19D304C1-6401-4D16-AB54-DD19C978D04D@redhat.com> <20210204090351.GN30079@redhat.com> <20210204092916.GS27779@redhat.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=rjones@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=rjones@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.351, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , qemu-devel@nongnu.org, David Hildenbrand Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Feb 04, 2021 at 05:04:22PM +0100, Philippe Mathieu-Daudé wrote: > On 2/4/21 10:37 AM, David Hildenbrand wrote: > > On 04.02.21 10:29, Richard W.M. Jones wrote: > >>>> commit 8f17a975e60b773d7c366a81c0d9bbe304f30859 > >>>> Author: Richard Henderson > >>>> Date:   Mon Mar 30 19:52:02 2020 -0700 > >>>> > >>>>      tcg/optimize: Adjust TempOptInfo allocation > >>>> > >>>> The image boots just fine on s390x/TCG as well. > >>> > >>> Let me try this in a minute on my original test machine. > >> > >> I got the wrong end of the stick as David pointed out in the other email. > >> > >> However I did test things again this morning (all on s390 host), and > >> current head (1ed9228f63ea4b) fails same as before ("mount" command > >> fails). > >> > >> Also I downloaded: > >> > >>    > >> https://dl.fedoraproject.org/pub/fedora-secondary/releases/33/Cloud/s390x/images/Fedora-Cloud-Base-33-1.2.s390x.qcow2 > >> > >> > >> and booted it on 1ed9228f63ea4b using this command: > >> > >>    $ ~/d/qemu/build/s390x-softmmu/qemu-system-s390x -machine accel=tcg > >> -m 2048 -drive > >> file=Fedora-Cloud-Base-33-1.2.s390x.qcow2,format=qcow2,if=virtio > >> -serial stdio > >> > >> Lots of core dumps inside the guest, same as David saw. > >> > >> I then reset qemu back to 8f17a975e60b773d ("tcg/optimize: Adjust > >> TempOptInfo allocation"), rebuilt qemu, tested the same command and > >> cloud image, and that booted up much happier with no failures or core > >> dumps. > >> > >> Isn't it kind of weird that this would only affect an s390 host?  I > >> don't understand why the host would make a difference if we're doing > >> TCG. > > > > I assume an existing BUG in the s390x TCG backend ... which makes it > > harder to debug :) > > This seems to fix it: > > -- >8 -- > diff --git a/tcg/s390/tcg-target.c.inc b/tcg/s390/tcg-target.c.inc > index 8517e552323..32d03dbfbaf 100644 > --- a/tcg/s390/tcg-target.c.inc > +++ b/tcg/s390/tcg-target.c.inc > @@ -1094,10 +1094,16 @@ static int tgen_cmp(TCGContext *s, TCGType type, > TCGCond c, TCGReg r1, > op = (is_unsigned ? RIL_CLFI : RIL_CFI); > tcg_out_insn_RIL(s, op, r1, c2); > goto exit; > - } else if (c2 == (is_unsigned ? (uint32_t)c2 : (int32_t)c2)) { > - op = (is_unsigned ? RIL_CLGFI : RIL_CGFI); > - tcg_out_insn_RIL(s, op, r1, c2); > - goto exit; > + } else if (is_unsigned) { > + if (c2 == (uint32_t)c2) { > + tcg_out_insn_RIL(s, RIL_CLGFI, r1, c2); > + goto exit; > + } > + } else { > + if (c2 == (int32_t)c2) { > + tcg_out_insn_RIL(s, RIL_CGFI, r1, c2); > + goto exit; > + } > } > } Thanks - can confirm this fixes both observed problems here. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html