[PATCH] exec/cpu-defs: Remove TCG backends dependency

[PATCH] exec/cpu-defs: Remove TCG backends dependency

[Philippe Mathieu-Daudé]

"exec/cpu-defs.h" contains common CPU definitions for
accelerators, which is not related to the TCG backends.
See tcg/README description:

  4) Backend

  tcg-target.h contains the target specific definitions. tcg-target.c.inc
  contains the target specific code; it is #included by tcg/tcg.c, rather
  than being a standalone C file.

So far only "tcg/tcg.h" requires these headers.

Remove the "target-tcg.h" header dependency on accelerators.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 include/exec/cpu-defs.h | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/include/exec/cpu-defs.h b/include/exec/cpu-defs.h
index d1f5e3fc3d8..ba3cd32a1ec 100644
--- a/include/exec/cpu-defs.h
+++ b/include/exec/cpu-defs.h
@@ -25,9 +25,6 @@
 
 #include "qemu/host-utils.h"
 #include "qemu/thread.h"
-#ifdef CONFIG_TCG
-#include "tcg-target.h"
-#endif
 #ifndef CONFIG_USER_ONLY
 #include "exec/hwaddr.h"
 #endif
-- 
2.26.2

Re: [PATCH] exec/cpu-defs: Remove TCG backends dependency

[Paolo Bonzini]

On 04/02/21 19:03, Philippe Mathieu-Daudé wrote:
> "exec/cpu-defs.h" contains common CPU definitions for
> accelerators, which is not related to the TCG backends.
> See tcg/README description:

Most of the definitions are actually for TCG, not for all accelerators 
(the TLB mostly).

However, they're indeed unrelated to the backends, so

Acked-by: Paolo Bonzini <pbonzini@redhat.com>

I'll let the TCG people pick it up.

Paolo

>    4) Backend
> 
>    tcg-target.h contains the target specific definitions. tcg-target.c.inc
>    contains the target specific code; it is #included by tcg/tcg.c, rather
>    than being a standalone C file.
> 
> So far only "tcg/tcg.h" requires these headers.
> 
> Remove the "target-tcg.h" header dependency on accelerators.
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>   include/exec/cpu-defs.h | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/include/exec/cpu-defs.h b/include/exec/cpu-defs.h
> index d1f5e3fc3d8..ba3cd32a1ec 100644
> --- a/include/exec/cpu-defs.h
> +++ b/include/exec/cpu-defs.h
> @@ -25,9 +25,6 @@
>   
>   #include "qemu/host-utils.h"
>   #include "qemu/thread.h"
> -#ifdef CONFIG_TCG
> -#include "tcg-target.h"
> -#endif
>   #ifndef CONFIG_USER_ONLY
>   #include "exec/hwaddr.h"
>   #endif
> 

Re: [PATCH] exec/cpu-defs: Remove TCG backends dependency

[Philippe Mathieu-Daudé]

On Thu, Feb 4, 2021 at 7:19 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
> On 04/02/21 19:03, Philippe Mathieu-Daudé wrote:
> > "exec/cpu-defs.h" contains common CPU definitions for
> > accelerators, which is not related to the TCG backends.
> > See tcg/README description:
>
> Most of the definitions are actually for TCG, not for all accelerators
> (the TLB mostly).

Ah ok. Richard, could you update the description or do you want
me to respin?

> However, they're indeed unrelated to the backends, so
>
> Acked-by: Paolo Bonzini <pbonzini@redhat.com>

Thanks, this avoids rebuilding the whole tree when doing a single change
in these headers (I'll send a quick mail about it later, proven useful while
bisecting).

Re: [PATCH] exec/cpu-defs: Remove TCG backends dependency

[Paolo Bonzini]

[-- Attachment #1: Type: text/plain, Size: 930 bytes --]

Il gio 4 feb 2021, 19:41 Philippe Mathieu-Daudé <f4bug@amsat.org> ha
scritto:

> On Thu, Feb 4, 2021 at 7:19 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
> > On 04/02/21 19:03, Philippe Mathieu-Daudé wrote:
> > > "exec/cpu-defs.h" contains common CPU definitions for
> > > accelerators, which is not related to the TCG backends.
> > > See tcg/README description:
> >
> > Most of the definitions are actually for TCG, not for all accelerators
> > (the TLB mostly).
>
> Ah ok. Richard, could you update the description or do you want
> me to respin?
>
> > However, they're indeed unrelated to the backends, so
> >
> > Acked-by: Paolo Bonzini <pbonzini@redhat.com>
>
> Thanks, this avoids rebuilding the whole tree when doing a single change
> in these headers (I'll send a quick mail about it later, proven useful
> while
> bisecting).
>

You could respin and include this info as well.

Paolo


>

[-- Attachment #2: Type: text/html, Size: 1734 bytes --]