qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] exec/cpu-defs: Remove TCG backends dependency
@ 2021-02-04 19:14 Philippe Mathieu-Daudé
  2021-02-04 19:43 ` Richard Henderson
  0 siblings, 1 reply; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-02-04 19:14 UTC (permalink / raw)
  To: qemu-devel
  Cc: Paolo Bonzini, Richard Henderson, Claudio Fontana,
	Philippe Mathieu-Daudé

"exec/cpu-defs.h" contains generic CPU definitions for the
TCG frontends (mostly related to TLB). TCG backends definitions
aren't relevant here.

See tcg/README description:

  4) Backend

  tcg-target.h contains the target specific definitions. tcg-target.c.inc
  contains the target specific code; it is #included by tcg/tcg.c, rather
  than being a standalone C file.

So far only "tcg/tcg.h" requires these headers.

Remove the "target-tcg.h" header dependency on TCG frontends, so we
don't have to rebuild all frontends when hacking a single backend.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
v2: Reword description (bonzini)
---
 include/exec/cpu-defs.h | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/include/exec/cpu-defs.h b/include/exec/cpu-defs.h
index d1f5e3fc3d8..ba3cd32a1ec 100644
--- a/include/exec/cpu-defs.h
+++ b/include/exec/cpu-defs.h
@@ -25,9 +25,6 @@
 
 #include "qemu/host-utils.h"
 #include "qemu/thread.h"
-#ifdef CONFIG_TCG
-#include "tcg-target.h"
-#endif
 #ifndef CONFIG_USER_ONLY
 #include "exec/hwaddr.h"
 #endif
-- 
2.26.2



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] exec/cpu-defs: Remove TCG backends dependency
  2021-02-04 19:14 [PATCH v2] exec/cpu-defs: Remove TCG backends dependency Philippe Mathieu-Daudé
@ 2021-02-04 19:43 ` Richard Henderson
  0 siblings, 0 replies; 2+ messages in thread
From: Richard Henderson @ 2021-02-04 19:43 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé, qemu-devel; +Cc: Paolo Bonzini, Claudio Fontana

On 2/4/21 9:14 AM, Philippe Mathieu-Daudé wrote:
> "exec/cpu-defs.h" contains generic CPU definitions for the
> TCG frontends (mostly related to TLB). TCG backends definitions
> aren't relevant here.
> 
> See tcg/README description:
> 
>   4) Backend
> 
>   tcg-target.h contains the target specific definitions. tcg-target.c.inc
>   contains the target specific code; it is #included by tcg/tcg.c, rather
>   than being a standalone C file.
> 
> So far only "tcg/tcg.h" requires these headers.
> 
> Remove the "target-tcg.h" header dependency on TCG frontends, so we
> don't have to rebuild all frontends when hacking a single backend.
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> v2: Reword description (bonzini)
> ---
>  include/exec/cpu-defs.h | 3 ---
>  1 file changed, 3 deletions(-)

Queued, thanks.


r~


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-02-04 19:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-04 19:14 [PATCH v2] exec/cpu-defs: Remove TCG backends dependency Philippe Mathieu-Daudé
2021-02-04 19:43 ` Richard Henderson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).