qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org
Cc: berrange@redhat.com, rjones@redhat.com, qemu-block@nongnu.org,
	Gerd Hoffmann <kraxel@redhat.com>
Subject: [PATCH] sockets: Use SOMAXCONN for Unix socket listen()
Date: Thu,  4 Feb 2021 16:20:18 -0600	[thread overview]
Message-ID: <20210204222018.1432848-1-eblake@redhat.com> (raw)

Our default of a backlog of 1 connection is rather puny, particularly
for scenarios where we expect multiple listeners to connect (such as
qemu-nbd -e X).  For Unix sockets, there's no real harm in supporting
a larger backlog, and a definite benefit to the clients: at least on
Linux, a client trying to connect to a Unix socket with a backlog gets
an EAGAIN failure with no way to poll() for when the backlog is no
longer present short of sleeping an arbitrary amount of time before
retrying.

See https://bugzilla.redhat.com/1925045 for a demonstration of where
our low backlog prevents libnbd from connecting as many parallel
clients as it wants.

Reported-by: Richard W.M. Jones <rjones@redhat.com>
Signed-off-by: Eric Blake <eblake@redhat.com>
---
 util/qemu-sockets.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c
index 8af0278f15c6..a7573e9f0fda 100644
--- a/util/qemu-sockets.c
+++ b/util/qemu-sockets.c
@@ -1059,7 +1059,7 @@ int unix_listen(const char *str, Error **errp)

     saddr = g_new0(UnixSocketAddress, 1);
     saddr->path = g_strdup(str);
-    sock = unix_listen_saddr(saddr, 1, errp);
+    sock = unix_listen_saddr(saddr, SOMAXCONN, errp);
     qapi_free_UnixSocketAddress(saddr);
     return sock;
 }
-- 
2.30.0



             reply	other threads:[~2021-02-04 22:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-04 22:20 Eric Blake [this message]
2021-02-05  9:55 ` [PATCH] sockets: Use SOMAXCONN for Unix socket listen() Daniel P. Berrangé
2021-02-05 19:04   ` Eric Blake
2021-02-05 10:01 ` Richard W.M. Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210204222018.1432848-1-eblake@redhat.com \
    --to=eblake@redhat.com \
    --cc=berrange@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rjones@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).