From: "Michael S. Tsirkin" <mst@redhat.com>
To: Yuri Benditovich <yuri.benditovich@daynix.com>
Cc: yan@daynix.com, jasowang@redhat.com, qemu-devel@nongnu.org
Subject: Re: [PATCH 3/3] virtio-net: graceful fallback to vhost=off for tap netdev
Date: Fri, 5 Feb 2021 08:43:39 -0500 [thread overview]
Message-ID: <20210205084018-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20210205083742-mutt-send-email-mst@kernel.org>
On Fri, Feb 05, 2021 at 08:38:49AM -0500, Michael S. Tsirkin wrote:
> On Thu, Feb 04, 2021 at 10:29:15PM +0200, Yuri Benditovich wrote:
> > Currently virtio-net silently clears features if they are
> > not supported by respective vhost. This may create migration
> > problems in future if vhost features on the source and destination
> > are different. Implement graceful fallback to no-vhost mode
> > when some acked features contradict with vhost. The decision is
> > taken on set_features call and the vhost will be disabled
> > till next reset (or migration).
> > Such fallback is currently enabled only for TAP netdev.
> >
> > Signed-off-by: Yuri Benditovich <yuri.benditovich@daynix.com>
>
>
> Sounds good, but I don't think we should do this if
> vhostforce=on is set.
>
> Also, let's document this behaviour with the vhost option so people
> are not suprized.
Here's another thing that bothers me.
At the moment we easily add new features, enabled by default,
as long as kernels are consistent on source and destination
everything works fine.
With this patch first time we add a new feature that kernel
does not support, vhost gets disabled. Given lots of people
update their kernels less frequently than userspace,
lots of users will start running with vhost off all of a sudden.
Don't have good suggestions yet.
--
MST
next prev parent reply other threads:[~2021-02-05 13:45 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 20:29 [PATCH 0/3] virtio-net: graceful drop of vhost for TAP Yuri Benditovich
2021-02-04 20:29 ` [PATCH 1/3] vhost-net: add VIRTIO_NET_F_HASH_REPORT to the list of kernel features Yuri Benditovich
2021-02-04 20:29 ` [PATCH 2/3] net: add ability to hide (disable) vhost_net Yuri Benditovich
2021-02-04 20:29 ` [PATCH 3/3] virtio-net: graceful fallback to vhost=off for tap netdev Yuri Benditovich
2021-02-05 13:38 ` Michael S. Tsirkin
2021-02-05 13:43 ` Michael S. Tsirkin [this message]
2021-02-08 3:15 ` Jason Wang
2021-02-08 19:46 ` Yuri Benditovich
2021-02-09 3:39 ` Jason Wang
2021-02-08 4:11 ` Jason Wang
2021-02-08 19:59 ` Yuri Benditovich
2021-02-09 3:45 ` Jason Wang
2021-02-09 14:34 ` [PATCH 0/3] virtio-net: graceful drop of vhost for TAP Michael S. Tsirkin
2021-02-09 14:51 ` Daniel P. Berrangé
2021-02-09 15:04 ` Michael S. Tsirkin
2021-02-09 15:18 ` Daniel P. Berrangé
2021-02-10 6:19 ` Jason Wang
2021-02-10 8:38 ` Michael S. Tsirkin
2021-02-18 3:02 ` Jason Wang
2021-02-18 9:35 ` Daniel P. Berrangé
2021-02-18 19:55 ` Yuri Benditovich
2021-02-19 9:35 ` Daniel P. Berrangé
2021-02-18 9:30 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210205084018-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yan@daynix.com \
--cc=yuri.benditovich@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).