From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D49E9C433DB for ; Fri, 5 Feb 2021 10:36:28 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4A80764F3B for ; Fri, 5 Feb 2021 10:36:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4A80764F3B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38066 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l7yTT-00010D-4H for qemu-devel@archiver.kernel.org; Fri, 05 Feb 2021 05:36:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50092) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l7yS1-00088Z-4T for qemu-devel@nongnu.org; Fri, 05 Feb 2021 05:34:58 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:32124) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l7yRx-0008Mh-PD for qemu-devel@nongnu.org; Fri, 05 Feb 2021 05:34:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612521292; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KNDAoa62uOQjpXHTg/AXimLcF8gkTUyZf3jXnbcawJw=; b=HYGBSv/w+vRQAJKHKgfPNQ49CUxyQInqTSD8yDGkU00GM08EsJSvw7Ue0jRVthak1lib45 2KTpU7w2dx05SYNiAv+ocd26leM9Z4M86Q0TCOIk5w75E+MEGCJYRtZQNNUWBhxka0XZQm 6Kj8sHFkbbNqrVqCYcDBhKKFLepL9j4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-427-fESdJDsIOwu0l5idt_Jwlg-1; Fri, 05 Feb 2021 05:34:49 -0500 X-MC-Unique: fESdJDsIOwu0l5idt_Jwlg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 07644100CCC3; Fri, 5 Feb 2021 10:34:48 +0000 (UTC) Received: from localhost (ovpn-114-98.ams2.redhat.com [10.36.114.98]) by smtp.corp.redhat.com (Postfix) with ESMTP id A71D160C9B; Fri, 5 Feb 2021 10:34:47 +0000 (UTC) Date: Fri, 5 Feb 2021 10:34:46 +0000 From: "Richard W.M. Jones" To: Eric Blake Subject: Re: [PATCH 3/3] utils: Deprecate inexact fractional suffix sizes Message-ID: <20210205103446.GC30079@redhat.com> References: <20210204190708.1306296-1-eblake@redhat.com> <20210204190708.1306296-4-eblake@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210204190708.1306296-4-eblake@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=rjones@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=rjones@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.351, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: vsementsov@virtuozzo.com, berrange@redhat.com, qemu-block@nongnu.org, tao3.xu@intel.com, qemu-devel@nongnu.org, armbru@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Feb 04, 2021 at 01:07:08PM -0600, Eric Blake wrote: > The value '1.1k' is inexact; 1126.4 bytes is not possible, so we > happen to truncate it to 1126. Our use of fractional sizes is > intended for convenience, but when a user specifies a fraction that is > not a clean translation to binary, truncating/rounding behind their > backs can cause confusion. Better is to deprecate inexact values, > which still leaves '1.5k' as valid, but alerts the user to spell out > their values as a precise byte number in cases where they are > currently being rounded. > > Note that values like '0.1G' in the testsuite need adjustment as a > result. > > Sadly, since qemu_strtosz() does not have an Err** parameter, we > pollute to stderr. Does "deprecate" mean there's a plan to eventually remove this? If so I think it should say that (in docs/system/deprecated.rst I think). I think it would be better to remove this now or in the future since it's a trap for users. Rich. > Signed-off-by: Eric Blake > --- > tests/test-cutils.c | 4 ++-- > tests/test-keyval.c | 4 ++-- > tests/test-qemu-opts.c | 4 ++-- > util/cutils.c | 4 ++++ > 4 files changed, 10 insertions(+), 6 deletions(-) > > diff --git a/tests/test-cutils.c b/tests/test-cutils.c > index 0c2c89d6f113..ad51fb1baa51 100644 > --- a/tests/test-cutils.c > +++ b/tests/test-cutils.c > @@ -2095,14 +2095,14 @@ static void test_qemu_strtosz_units(void) > > static void test_qemu_strtosz_float(void) > { > - const char *str = "12.345M"; > + const char *str = "12.125M"; > int err; > const char *endptr; > uint64_t res = 0xbaadf00d; > > err = qemu_strtosz(str, &endptr, &res); > g_assert_cmpint(err, ==, 0); > - g_assert_cmpint(res, ==, 12.345 * MiB); > + g_assert_cmpint(res, ==, 12.125 * MiB); > g_assert(endptr == str + 7); > } > > diff --git a/tests/test-keyval.c b/tests/test-keyval.c > index 13be763650b2..c951ac54cd23 100644 > --- a/tests/test-keyval.c > +++ b/tests/test-keyval.c > @@ -522,7 +522,7 @@ static void test_keyval_visit_size(void) > visit_free(v); > > /* Suffixes */ > - qdict = keyval_parse("sz1=8b,sz2=1.5k,sz3=2M,sz4=0.1G,sz5=16777215T", > + qdict = keyval_parse("sz1=8b,sz2=1.5k,sz3=2M,sz4=0.125G,sz5=16777215T", > NULL, NULL, &error_abort); > v = qobject_input_visitor_new_keyval(QOBJECT(qdict)); > qobject_unref(qdict); > @@ -534,7 +534,7 @@ static void test_keyval_visit_size(void) > visit_type_size(v, "sz3", &sz, &error_abort); > g_assert_cmphex(sz, ==, 2 * MiB); > visit_type_size(v, "sz4", &sz, &error_abort); > - g_assert_cmphex(sz, ==, GiB / 10); > + g_assert_cmphex(sz, ==, GiB / 8); > visit_type_size(v, "sz5", &sz, &error_abort); > g_assert_cmphex(sz, ==, 16777215ULL * TiB); > visit_check_struct(v, &error_abort); > diff --git a/tests/test-qemu-opts.c b/tests/test-qemu-opts.c > index f79b698e6715..6a1ea1d01c4f 100644 > --- a/tests/test-qemu-opts.c > +++ b/tests/test-qemu-opts.c > @@ -717,10 +717,10 @@ static void test_opts_parse_size(void) > g_assert_cmphex(qemu_opt_get_size(opts, "size1", 0), ==, 8); > g_assert_cmphex(qemu_opt_get_size(opts, "size2", 0), ==, 1536); > g_assert_cmphex(qemu_opt_get_size(opts, "size3", 0), ==, 2 * MiB); > - opts = qemu_opts_parse(&opts_list_02, "size1=0.1G,size2=16777215T", > + opts = qemu_opts_parse(&opts_list_02, "size1=0.125G,size2=16777215T", > false, &error_abort); > g_assert_cmpuint(opts_count(opts), ==, 2); > - g_assert_cmphex(qemu_opt_get_size(opts, "size1", 0), ==, GiB / 10); > + g_assert_cmphex(qemu_opt_get_size(opts, "size1", 0), ==, GiB / 8); > g_assert_cmphex(qemu_opt_get_size(opts, "size2", 0), ==, 16777215ULL * TiB); > > /* Beyond limit with suffix */ > diff --git a/util/cutils.c b/util/cutils.c > index 75190565cbb5..5ec6101ae778 100644 > --- a/util/cutils.c > +++ b/util/cutils.c > @@ -327,6 +327,10 @@ static int do_strtosz(const char *nptr, const char **end, > retval = -ERANGE; > goto out; > } > + if (mul_required && fraction * mul != (uint64_t) (fraction * mul)) { > + fprintf(stderr, "Using a fractional size that is not an exact byte " > + "multiple is deprecated: %s\n", nptr); > + } > *result = val * mul + (uint64_t) (fraction * mul); > retval = 0; > > -- > 2.30.0 -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supported. http://fedoraproject.org/wiki/MinGW