From: "Michael S. Tsirkin" <mst@redhat.com>
To: Marian Postevca <posteuca@mutex.one>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Sergio Lopez <slp@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
Ben Warren <ben@skyportsystems.com>,
Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, Dongjiu Geng <gengdongjiu@huawei.com>,
Shannon Zhao <shannon.zhaosl@gmail.com>,
Xiang Zheng <zhengxiang9@huawei.com>,
qemu-arm@nongnu.org, Igor Mammedov <imammedo@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Xiao Guangrong <xiaoguangrong.eric@gmail.com>
Subject: Re: [PATCH v4 2/5] acpi: Permit OEM ID and OEM table ID fields to be changed
Date: Sun, 7 Feb 2021 13:43:01 -0500 [thread overview]
Message-ID: <20210207134214-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <87h7mnzqhm.fsf@mutex.one>
On Sun, Feb 07, 2021 at 08:23:33PM +0200, Marian Postevca wrote:
> "Michael S. Tsirkin" <mst@redhat.com> writes:
>
> >
> >
> > I queued this but there's a lot of code duplication with this.
> > Further, the use of g_strdup adds unnecessary dynamic memory
> > management where it's not needed.
> > I'd prefer
> > - a new struct AcpiBuildOem including the correct strings
> > - use sizeof of fields in above instead of 8/6
> > - move shared strings and code into a common header
> >
>
> So how should I approach this since the patches are queued? A new patch
> with the suggested changes, or resending the original patches?
A patch on top please. They are merged so really easy, just basing on
masted should be good.
--
MST
next prev parent reply other threads:[~2021-02-07 18:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 0:32 [PATCH v4 0/5] acpi: Permit OEM ID and OEM table ID fields to be changed Marian Postevca
2021-01-19 0:32 ` [PATCH v4 1/5] tests/acpi: allow updates for expected data files Marian Postevca
2021-01-19 0:32 ` [PATCH v4 2/5] acpi: Permit OEM ID and OEM table ID fields to be changed Marian Postevca
2021-02-05 13:30 ` Michael S. Tsirkin
2021-02-07 18:23 ` Marian Postevca
2021-02-07 18:43 ` Michael S. Tsirkin [this message]
2021-01-19 0:32 ` [PATCH v4 3/5] tests/acpi: add OEM ID and OEM TABLE ID test Marian Postevca
2021-01-19 0:32 ` [PATCH v4 4/5] tests/acpi: update expected data files Marian Postevca
2021-01-19 0:32 ` [PATCH v4 5/5] tests/acpi: disallow updates for " Marian Postevca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210207134214-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=ben@skyportsystems.com \
--cc=ehabkost@redhat.com \
--cc=gengdongjiu@huawei.com \
--cc=imammedo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=posteuca@mutex.one \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=shannon.zhaosl@gmail.com \
--cc=slp@redhat.com \
--cc=xiaoguangrong.eric@gmail.com \
--cc=zhengxiang9@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).