From: David Gibson <david@gibson.dropbear.id.au>
To: pair@us.ibm.com, qemu-devel@nongnu.org, peter.maydell@linaro.org,
dgilbert@redhat.com, brijesh.singh@amd.com, pasic@linux.ibm.com
Cc: qemu-ppc@nongnu.org, Thomas Huth <thuth@redhat.com>,
cohuck@redhat.com, berrange@redhat.com, ehabkost@redhat.com,
kvm@vger.kernel.org, david@redhat.com, jun.nakajima@intel.com,
mtosatti@redhat.com, richard.henderson@linaro.org,
mdroth@linux.vnet.ibm.com, Greg Kurz <groug@kaod.org>,
borntraeger@de.ibm.com, qemu-s390x@nongnu.org,
frankja@linux.ibm.com, mst@redhat.com,
pragyansri.pathi@intel.com, andi.kleen@intel.com,
Paolo Bonzini <pbonzini@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: [PULL v9 11/13] spapr: PEF: prevent migration
Date: Mon, 8 Feb 2021 17:07:33 +1100 [thread overview]
Message-ID: <20210208060735.39838-12-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20210208060735.39838-1-david@gibson.dropbear.id.au>
We haven't yet implemented the fairly involved handshaking that will be
needed to migrate PEF protected guests. For now, just use a migration
blocker so we get a meaningful error if someone attempts this (this is the
same approach used by AMD SEV).
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
---
hw/ppc/pef.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/hw/ppc/pef.c b/hw/ppc/pef.c
index f9fd1f2a71..573be3ed79 100644
--- a/hw/ppc/pef.c
+++ b/hw/ppc/pef.c
@@ -44,6 +44,8 @@ struct PefGuest {
static int kvmppc_svm_init(Error **errp)
{
#ifdef CONFIG_KVM
+ static Error *pef_mig_blocker;
+
if (!kvm_check_extension(kvm_state, KVM_CAP_PPC_SECURE_GUEST)) {
error_setg(errp,
"KVM implementation does not support Secure VMs (is an ultravisor running?)");
@@ -58,6 +60,11 @@ static int kvmppc_svm_init(Error **errp)
}
}
+ /* add migration blocker */
+ error_setg(&pef_mig_blocker, "PEF: Migration is not implemented");
+ /* NB: This can fail if --only-migratable is used */
+ migrate_add_blocker(pef_mig_blocker, &error_fatal);
+
return 0;
#else
g_assert_not_reached();
--
2.29.2
next prev parent reply other threads:[~2021-02-08 12:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 6:07 [PULL v9 00/13] Cgs patches David Gibson
2021-02-08 6:07 ` [PULL v9 01/13] qom: Allow optional sugar props David Gibson
2021-02-08 6:07 ` [PULL v9 02/13] confidential guest support: Introduce new confidential guest support class David Gibson
2021-02-08 6:07 ` [PULL v9 03/13] sev: Remove false abstraction of flash encryption David Gibson
2021-02-08 6:07 ` [PULL v9 04/13] confidential guest support: Move side effect out of machine_set_memory_encryption() David Gibson
2021-02-08 6:07 ` [PULL v9 05/13] confidential guest support: Rework the "memory-encryption" property David Gibson
2021-02-08 6:07 ` [PULL v9 06/13] sev: Add Error ** to sev_kvm_init() David Gibson
2021-02-08 6:07 ` [PULL v9 07/13] confidential guest support: Introduce cgs "ready" flag David Gibson
2021-02-08 6:07 ` [PULL v9 08/13] confidential guest support: Move SEV initialization into arch specific code David Gibson
2021-02-08 6:07 ` [PULL v9 09/13] confidential guest support: Update documentation David Gibson
2021-02-08 6:07 ` [PULL v9 10/13] spapr: Add PEF based confidential guest support David Gibson
2021-02-08 6:07 ` David Gibson [this message]
2021-02-08 6:07 ` [PULL v9 12/13] confidential guest support: Alter virtio default properties for protected guests David Gibson
2021-02-08 6:07 ` [PULL v9 13/13] s390: Recognize confidential-guest-support option David Gibson
-- strict thread matches above, loose matches on Subject: below --
2021-02-08 6:05 [PULL v9 00/13] Cgs patches David Gibson
2021-02-08 6:05 ` [PULL v9 11/13] spapr: PEF: prevent migration David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210208060735.39838-12-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=andi.kleen@intel.com \
--cc=berrange@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=brijesh.singh@amd.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=groug@kaod.org \
--cc=jun.nakajima@intel.com \
--cc=kvm@vger.kernel.org \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pair@us.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=pragyansri.pathi@intel.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).