From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C472BC433DB for ; Mon, 8 Feb 2021 17:36:48 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4ECDD64E5D for ; Mon, 8 Feb 2021 17:36:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4ECDD64E5D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35980 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9ASt-0000xb-25 for qemu-devel@archiver.kernel.org; Mon, 08 Feb 2021 12:36:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38304) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l94Gm-0002Hw-3q for qemu-devel@nongnu.org; Mon, 08 Feb 2021 05:59:52 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:37106) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l94GV-0001pk-SD for qemu-devel@nongnu.org; Mon, 08 Feb 2021 05:59:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612781974; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Mb9snAn/xcduVdRN+Q2ylcojHAmzKps4kfLjg/8hWW8=; b=PPxkAmjGQrCi9SWVRnYSd7Z9cuuPx1oro16eKzcKvi5/ppl6oJI83/L8PWBukAC+9TNMPY zduSwJSL89hjjDviKnHnhhRflTgvYHOVGCNmQYZaF3/fsnuhFI3NOHLClK3JeRh9c4EhsR CDMJZZyqwrkNblftrPrVk5K2WlgKK9w= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-350-YOTtCalnOBux0Q4gRub_cA-1; Mon, 08 Feb 2021 05:59:33 -0500 X-MC-Unique: YOTtCalnOBux0Q4gRub_cA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id ED567801965; Mon, 8 Feb 2021 10:59:31 +0000 (UTC) Received: from work-vm (ovpn-115-22.ams2.redhat.com [10.36.115.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D7224101E245; Mon, 8 Feb 2021 10:59:30 +0000 (UTC) Date: Mon, 8 Feb 2021 10:59:27 +0000 From: "Dr. David Alan Gilbert" To: Stefan Reiter Subject: Re: [PATCH] migration: only check page size match if RAM postcopy is enabled Message-ID: <20210208105927.GA28440@work-vm> References: <20210204163522.13291-1-s.reiter@proxmox.com> MIME-Version: 1.0 In-Reply-To: <20210204163522.13291-1-s.reiter@proxmox.com> User-Agent: Mutt/1.14.6 (2020-07-11) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dgilbert@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=63.128.21.124; envelope-from=dgilbert@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -33 X-Spam_score: -3.4 X-Spam_bar: --- X-Spam_report: (-3.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.569, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org, Juan Quintela Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Stefan Reiter (s.reiter@proxmox.com) wrote: > Postcopy may also be advised for dirty-bitmap migration only, in which > case the remote page size will not be available and we'll instead read > bogus data, blocking migration with a mismatch error if the VM uses > hugepages. > > Fixes: 58110f0acb ("migration: split common postcopy out of ram postcopy") > Signed-off-by: Stefan Reiter Queued > --- > migration/ram.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/migration/ram.c b/migration/ram.c > index 7811cde643..6ace15261c 100644 > --- a/migration/ram.c > +++ b/migration/ram.c > @@ -3521,7 +3521,7 @@ static int ram_load_precopy(QEMUFile *f) > } > } > /* For postcopy we need to check hugepage sizes match */ > - if (postcopy_advised && > + if (postcopy_advised && migrate_postcopy_ram() && > block->page_size != qemu_host_page_size) { > uint64_t remote_page_size = qemu_get_be64(f); > if (remote_page_size != block->page_size) { > -- > 2.20.1 > > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK