From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12683C433DB for ; Mon, 8 Feb 2021 22:43:43 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A1C8B64E7A for ; Mon, 8 Feb 2021 22:43:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A1C8B64E7A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48958 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9FFt-0007vR-On for qemu-devel@archiver.kernel.org; Mon, 08 Feb 2021 17:43:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47286) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9B2O-0007Ac-DY for qemu-devel@nongnu.org; Mon, 08 Feb 2021 13:13:29 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:28239) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l9B2H-0001Oy-Qo for qemu-devel@nongnu.org; Mon, 08 Feb 2021 13:13:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612808000; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ub3jalqzcLI03GkqHpNeQqNsICUS0uQ2g98wLs+GytU=; b=i3tbV+1xNYNawv5vlWjpWP5Z8NABDz7GqvrcQ6LVawJYUGNdQmk0tKxbC5TicUCgRpPMUk BuENamildtVb9VYXe8rhlMwNKcjCKEm7fB7QUFiyfqTSsoro423fzodijMBuO5k4tpv7TT Dm3FET2bHbC83zGY1obbpMSaq5Neg+U= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-371-0I15naYZOxi1Uj1fzskkIg-1; Mon, 08 Feb 2021 13:13:06 -0500 X-MC-Unique: 0I15naYZOxi1Uj1fzskkIg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7ABC4BBEE4; Mon, 8 Feb 2021 18:13:05 +0000 (UTC) Received: from redhat.com (ovpn-115-97.ams2.redhat.com [10.36.115.97]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5E37F5D9DC; Mon, 8 Feb 2021 18:12:51 +0000 (UTC) Date: Mon, 8 Feb 2021 18:12:35 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [PATCH 0/3] fix build failures from incorrectly skipped container build jobs Message-ID: <20210208181235.GN1141037@redhat.com> References: <20210208163339.1159514-1-berrange@redhat.com> <20210208172256.GM1141037@redhat.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.14.6 (2020-07-11) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -33 X-Spam_score: -3.4 X-Spam_bar: --- X-Spam_report: (-3.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.57, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Thomas Huth , Stefan Weil , qemu-devel@nongnu.org, Wainer dos Santos Moschetta , Yonggang Luo , Sunil Muthuswamy , Alex =?utf-8?Q?Benn=C3=A9e?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Feb 08, 2021 at 07:08:39PM +0100, Philippe Mathieu-Daudé wrote: > On 2/8/21 6:22 PM, Daniel P. Berrangé wrote: > > On Mon, Feb 08, 2021 at 04:33:36PM +0000, Daniel P. Berrangé wrote: > >> This series fixes a problem with our gitlab CI rules that cause > >> container builds to be skipped. See the commit description in the > >> first patch for the details on this problem. > >> > >> The overall result of this series though is a small increase in overall > >> pipeline time. > >> > >> Previously > >> > >> - When container jobs are skipped: approx 1hr 5 mins > >> - When container jobs are run, cached by docker: approx 1hr 15 mins > >> - When container jobs are run, not cached by docker: approx 1hr 30 mins > >> > >> With this series applied the first scenario no longer exists, so > >> all piplines are either 1hr 15 or 1hr 30 depending on whether the > >> container phase is skipped. > > > > I mean to say the biggest problem I see is the cross-win64-system > > job. This consumes 1 hour 5 minutes all on its own. It is at least > > 15 minutes longer that every other job AFAICT. So no matter how > > well we parallelize stuff, 1 hr 5 is a hard lower limit on pipeline > > duration right now. > > > > We might want to consider how to split the win64 job or cut down > > what it does in some way ? > > When the win64 build was added (on Debian), it was to mostly to cover > the WHPX. Later we moved mingw jobs to Fedora. I just checked and > WHPX is no more built, and nobody complained, so it is not relevant > anymore. > > I don't mind much what you do with the Gitlab win64 job, as this config > is better covered on Cirrus. I'd like to keep the win32 job because it > has been useful to catch 32-bit issues. I'm not suggesting we remove it. Most developers won't setup Cirrus CI, so will only run GitLab CI jobs. IME it is good to have both win32 and win64 coverage because things do break differently on them - especially if you use bad printf format strings that are not independant of host word size Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|