qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: Auger Eric <eric.auger@redhat.com>
Cc: "Michael S . Tsirkin" <mst@redhat.com>,
	Jean-Philippe Brucker <Jean-Philippe.Brucker@arm.com>,
	Jason Wang <jasowang@redhat.com>,
	qemu-devel@nongnu.org, Eugenio Perez Martin <eperezma@redhat.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH] vhost: Unbreak SMMU and virtio-iommu on dev-iotlb support
Date: Tue, 9 Feb 2021 14:46:58 -0500	[thread overview]
Message-ID: <20210209194658.GA103365@xz-x1> (raw)
In-Reply-To: <6ddf3db5-552a-4984-5f52-836178e5f486@redhat.com>

On Tue, Feb 09, 2021 at 06:15:11PM +0100, Auger Eric wrote:
> I just noted that the vhost fix now breaks virtio-iommu/vfio integration
> because VFIO registers IOMMU_NOTIFIER_ALL which includes the DEV-IOTLB
> that is now rejected by virtio-iommu virtio_iommu_notify_flag_changed().
> Is it safe to replace IOMMU_NOTIFIER_ALL by IOMMU_NOTIFIER_IOTLB_EVENTS
> in vfio_listener_region_add (hw/vfio/common.c) or shall we also do the
> 2-step registration? After your confirmation, I can send the patch.

Thanks for noticing this, Eric.  Indeed there're a bunch of things that we'd
overlooked.

I think IOMMU_NOTIFIER_IOTLB_EVENTS should suffice with vfio.

If you post that patch, would you mind post a similar fix for PPC too which
will need the two-step thing?  Assuming they can be in the same series to fix
the breakage of that same patch.

CC Alex and David Gibson.

Thanks,

-- 
Peter Xu



      reply	other threads:[~2021-02-09 20:26 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-04 19:12 [PATCH] vhost: Unbreak SMMU and virtio-iommu on dev-iotlb support Peter Xu
2021-02-05  3:16 ` Jason Wang
2021-02-05  8:33   ` Auger Eric
2021-02-05 15:31     ` Peter Xu
2021-02-07  9:04       ` Tian, Kevin
2021-02-07 14:47         ` Peter Xu
2021-02-08  7:03           ` Tian, Kevin
2021-02-08 18:26             ` Peter Xu
2021-02-10  4:05               ` Jason Wang
2021-02-08 20:23           ` Auger Eric
2021-02-08  3:21       ` Jason Wang
2021-02-08 18:37         ` Peter Xu
2021-02-08 20:30           ` Auger Eric
2021-02-09  3:12           ` Jason Wang
2021-02-09 17:15             ` Auger Eric
2021-02-09 19:46               ` Peter Xu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210209194658.GA103365@xz-x1 \
    --to=peterx@redhat.com \
    --cc=Jean-Philippe.Brucker@arm.com \
    --cc=alex.williamson@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=eperezma@redhat.com \
    --cc=eric.auger@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).