From: Stefan Hajnoczi <stefanha@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: "Fam Zheng" <fam@euphon.net>,
"John G Johnson" <john.g.johnson@oracle.com>,
thuth@redhat.com, "Jagannathan Raman" <jag.raman@oracle.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
qemu-block@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
"Denis V. Lunev" <den@openvz.org>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Elena Ufimtseva" <elena.ufimtseva@oracle.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: [PULL v4 26/27] multi-process: perform device reset in the remote process
Date: Wed, 10 Feb 2021 09:26:27 +0000 [thread overview]
Message-ID: <20210210092628.193785-27-stefanha@redhat.com> (raw)
In-Reply-To: <20210210092628.193785-1-stefanha@redhat.com>
From: Elena Ufimtseva <elena.ufimtseva@oracle.com>
Perform device reset in the remote process when QEMU performs
device reset. This is required to reset the internal state
(like registers, etc...) of emulated devices
Signed-off-by: Elena Ufimtseva <elena.ufimtseva@oracle.com>
Signed-off-by: John G Johnson <john.g.johnson@oracle.com>
Signed-off-by: Jagannathan Raman <jag.raman@oracle.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-id: 7cb220a51f565dc0817bd76e2f540e89c2d2b850.1611938319.git.jag.raman@oracle.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
include/hw/remote/mpqemu-link.h | 1 +
hw/remote/message.c | 22 ++++++++++++++++++++++
hw/remote/proxy.c | 19 +++++++++++++++++++
3 files changed, 42 insertions(+)
diff --git a/include/hw/remote/mpqemu-link.h b/include/hw/remote/mpqemu-link.h
index 71d206f00e..4ec0915885 100644
--- a/include/hw/remote/mpqemu-link.h
+++ b/include/hw/remote/mpqemu-link.h
@@ -40,6 +40,7 @@ typedef enum {
MPQEMU_CMD_BAR_WRITE,
MPQEMU_CMD_BAR_READ,
MPQEMU_CMD_SET_IRQFD,
+ MPQEMU_CMD_DEVICE_RESET,
MPQEMU_CMD_MAX,
} MPQemuCmd;
diff --git a/hw/remote/message.c b/hw/remote/message.c
index adab040ca1..11d729845c 100644
--- a/hw/remote/message.c
+++ b/hw/remote/message.c
@@ -19,6 +19,7 @@
#include "exec/memattrs.h"
#include "hw/remote/memory.h"
#include "hw/remote/iohub.h"
+#include "sysemu/reset.h"
static void process_config_write(QIOChannel *ioc, PCIDevice *dev,
MPQemuMsg *msg, Error **errp);
@@ -26,6 +27,8 @@ static void process_config_read(QIOChannel *ioc, PCIDevice *dev,
MPQemuMsg *msg, Error **errp);
static void process_bar_write(QIOChannel *ioc, MPQemuMsg *msg, Error **errp);
static void process_bar_read(QIOChannel *ioc, MPQemuMsg *msg, Error **errp);
+static void process_device_reset_msg(QIOChannel *ioc, PCIDevice *dev,
+ Error **errp);
void coroutine_fn mpqemu_remote_msg_loop_co(void *data)
{
@@ -69,6 +72,9 @@ void coroutine_fn mpqemu_remote_msg_loop_co(void *data)
case MPQEMU_CMD_SET_IRQFD:
process_set_irqfd_msg(pci_dev, &msg);
break;
+ case MPQEMU_CMD_DEVICE_RESET:
+ process_device_reset_msg(com->ioc, pci_dev, &local_err);
+ break;
default:
error_setg(&local_err,
"Unknown command (%d) received for device %s"
@@ -206,3 +212,19 @@ fail:
getpid());
}
}
+
+static void process_device_reset_msg(QIOChannel *ioc, PCIDevice *dev,
+ Error **errp)
+{
+ DeviceClass *dc = DEVICE_GET_CLASS(dev);
+ DeviceState *s = DEVICE(dev);
+ MPQemuMsg ret = { 0 };
+
+ if (dc->reset) {
+ dc->reset(s);
+ }
+
+ ret.cmd = MPQEMU_CMD_RET;
+
+ mpqemu_msg_send(&ret, ioc, errp);
+}
diff --git a/hw/remote/proxy.c b/hw/remote/proxy.c
index a082709881..4fa4be079d 100644
--- a/hw/remote/proxy.c
+++ b/hw/remote/proxy.c
@@ -26,6 +26,7 @@
#include "util/event_notifier-posix.c"
static void probe_pci_info(PCIDevice *dev, Error **errp);
+static void proxy_device_reset(DeviceState *dev);
static void proxy_intx_update(PCIDevice *pci_dev)
{
@@ -202,6 +203,8 @@ static void pci_proxy_dev_class_init(ObjectClass *klass, void *data)
k->config_read = pci_proxy_read_config;
k->config_write = pci_proxy_write_config;
+ dc->reset = proxy_device_reset;
+
device_class_set_props(dc, proxy_properties);
}
@@ -358,3 +361,19 @@ static void probe_pci_info(PCIDevice *dev, Error **errp)
}
}
}
+
+static void proxy_device_reset(DeviceState *dev)
+{
+ PCIProxyDev *pdev = PCI_PROXY_DEV(dev);
+ MPQemuMsg msg = { 0 };
+ Error *local_err = NULL;
+
+ msg.cmd = MPQEMU_CMD_DEVICE_RESET;
+ msg.size = 0;
+
+ mpqemu_msg_send_and_await_reply(&msg, pdev, &local_err);
+ if (local_err) {
+ error_report_err(local_err);
+ }
+
+}
--
2.29.2
next prev parent reply other threads:[~2021-02-10 9:52 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 9:26 [PULL v4 00/27] Block patches Stefan Hajnoczi
2021-02-10 9:26 ` [PULL v4 01/27] .github: point Repo Lockdown bot to GitLab repo Stefan Hajnoczi
2021-02-10 9:26 ` [PULL v4 02/27] gitmodules: use GitLab repos instead of qemu.org Stefan Hajnoczi
2021-02-10 9:26 ` [PULL v4 03/27] gitlab-ci: remove redundant GitLab repo URL command Stefan Hajnoczi
2021-02-10 9:26 ` [PULL v4 04/27] docs: update README to use GitLab repo URLs Stefan Hajnoczi
2021-02-10 9:26 ` [PULL v4 05/27] pc-bios: update mirror URLs to GitLab Stefan Hajnoczi
2021-02-10 9:26 ` [PULL v4 06/27] get_maintainer: update repo URL " Stefan Hajnoczi
2021-02-10 9:26 ` [PULL v4 07/27] multi-process: add the concept description to docs/devel/qemu-multiprocess Stefan Hajnoczi
2023-06-06 14:21 ` Philippe Mathieu-Daudé
2021-02-10 9:26 ` [PULL v4 08/27] multi-process: add configure and usage information Stefan Hajnoczi
2021-02-10 9:26 ` [PULL v4 09/27] memory: alloc RAM from file at offset Stefan Hajnoczi
2021-02-10 9:26 ` [PULL v4 10/27] multi-process: Add config option for multi-process QEMU Stefan Hajnoczi
2021-02-10 9:26 ` [PULL v4 11/27] multi-process: setup PCI host bridge for remote device Stefan Hajnoczi
2021-02-10 9:26 ` [PULL v4 12/27] multi-process: setup a machine object for remote device process Stefan Hajnoczi
2021-02-10 9:26 ` [PULL v4 13/27] io: add qio_channel_writev_full_all helper Stefan Hajnoczi
2021-02-10 9:26 ` [PULL v4 14/27] io: add qio_channel_readv_full_all_eof & qio_channel_readv_full_all helpers Stefan Hajnoczi
2021-02-11 15:34 ` Max Reitz
2021-02-11 15:46 ` Daniel P. Berrangé
2021-02-11 15:48 ` Jag Raman
2021-02-10 9:26 ` [PULL v4 15/27] multi-process: define MPQemuMsg format and transmission functions Stefan Hajnoczi
2021-02-10 9:26 ` [PULL v4 16/27] multi-process: Initialize message handler in remote device Stefan Hajnoczi
2021-02-10 9:26 ` [PULL v4 17/27] multi-process: Associate fd of a PCIDevice with its object Stefan Hajnoczi
2021-02-10 9:26 ` [PULL v4 18/27] multi-process: setup memory manager for remote device Stefan Hajnoczi
2021-02-10 9:26 ` [PULL v4 19/27] multi-process: introduce proxy object Stefan Hajnoczi
2021-02-10 9:26 ` [PULL v4 20/27] multi-process: add proxy communication functions Stefan Hajnoczi
2021-02-10 9:26 ` [PULL v4 21/27] multi-process: Forward PCI config space acceses to the remote process Stefan Hajnoczi
2021-02-10 9:26 ` [PULL v4 22/27] multi-process: PCI BAR read/write handling for proxy & remote endpoints Stefan Hajnoczi
2021-02-10 9:26 ` [PULL v4 23/27] multi-process: Synchronize remote memory Stefan Hajnoczi
2021-02-10 9:26 ` [PULL v4 24/27] multi-process: create IOHUB object to handle irq Stefan Hajnoczi
2021-02-10 9:26 ` [PULL v4 25/27] multi-process: Retrieve PCI info from remote process Stefan Hajnoczi
2021-02-10 9:26 ` Stefan Hajnoczi [this message]
2021-02-10 9:26 ` [PULL v4 27/27] docs: fix Parallels Image "dirty bitmap" section Stefan Hajnoczi
2021-02-10 17:33 ` [PULL v4 00/27] Block patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210210092628.193785-27-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=den@openvz.org \
--cc=ehabkost@redhat.com \
--cc=elena.ufimtseva@oracle.com \
--cc=fam@euphon.net \
--cc=imammedo@redhat.com \
--cc=jag.raman@oracle.com \
--cc=john.g.johnson@oracle.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).