From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E604AC433DB for ; Wed, 10 Feb 2021 11:36:24 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4211A64E38 for ; Wed, 10 Feb 2021 11:36:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4211A64E38 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:39856 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9nnB-0005GF-Kr for qemu-devel@archiver.kernel.org; Wed, 10 Feb 2021 06:36:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57812) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9nlp-0004Wu-V4 for qemu-devel@nongnu.org; Wed, 10 Feb 2021 06:34:57 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:41701) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l9nln-0004jR-0D for qemu-devel@nongnu.org; Wed, 10 Feb 2021 06:34:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612956893; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0Y4jD9GWAIzRvwoStYd5V+JXjl55L3SpZO8bLSVs1ig=; b=bPG+i5y+FvAnb8q20/2sKADBWFh9slknbzQ4Zff8ntHen84b2xrAOOYCwPAH+hfMHJ7XMN 5OT+5mrzkcimrFbRiZ74Ab9mzqQ8B9emdOKGGGDCck8I5kBDG4GjnY/qqFVlM5I24Rf2zx R2IaoqPtXJKv1T9ZJLznVIa642XB4sI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-466-xwZVkVOHOGqvxIdp5hxHrw-1; Wed, 10 Feb 2021 06:34:51 -0500 X-MC-Unique: xwZVkVOHOGqvxIdp5hxHrw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EC732835E22; Wed, 10 Feb 2021 11:34:49 +0000 (UTC) Received: from redhat.com (ovpn-115-94.ams2.redhat.com [10.36.115.94]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9B27019C66; Wed, 10 Feb 2021 11:34:45 +0000 (UTC) Date: Wed, 10 Feb 2021 11:34:42 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [PATCH v2] hw/block: nvme: Fix a build error in nvme_get_feature() Message-ID: <20210210113442.GG1240644@redhat.com> References: <1612952597-62595-1-git-send-email-bmeng.cn@gmail.com> <299d3bdc-268c-eccc-66be-6605b23a2c92@redhat.com> <20210210112219.GF1240644@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210210112219.GF1240644@redhat.com> User-Agent: Mutt/1.14.6 (2020-07-11) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -33 X-Spam_score: -3.4 X-Spam_bar: --- X-Spam_report: (-3.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.57, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Kevin Wolf , Peter Maydell , Thomas Huth , qemu-block@nongnu.org, Bin Meng , qemu-devel@nongnu.org, Max Reitz , Keith Busch , Minwoo Im , Klaus Jensen , Bin Meng , Alex =?utf-8?Q?Benn=C3=A9e?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Feb 10, 2021 at 11:22:19AM +0000, Daniel P. Berrangé wrote: > On Wed, Feb 10, 2021 at 12:15:45PM +0100, Philippe Mathieu-Daudé wrote: > > On 2/10/21 12:12 PM, Philippe Mathieu-Daudé wrote: > > > Hi Bin, > > > > > > On 2/10/21 11:23 AM, Bin Meng wrote: > > >> From: Bin Meng > > >> > > >> Current QEMU HEAD nvme.c does not compile: > > >> > > >> hw/block/nvme.c:3242:9: error: ‘result’ may be used uninitialized in this function [-Werror=maybe-uninitialized] > > >> trace_pci_nvme_getfeat_vwcache(result ? "enabled" : "disabled"); > > >> ^ > > >> hw/block/nvme.c:3150:14: note: ‘result’ was declared here > > >> uint32_t result; > > >> ^ > > > > > > Why isn't this catched by our CI? What is your host OS? Fedora 33? > > > > Just noticed v1 and Peter's explanation: > > https://lists.gnu.org/archive/html/qemu-devel/2021-02/msg03528.html > > > > Can you amend "default GCC 5.4 on a Ubuntu 16.04 host" information > > please? > > Well Ubuntu 16.04 hasn't been considered a supported build target for > QEMU for a year now. > > https://qemu.readthedocs.io/en/latest/system/build-platforms.html#linux-os-macos-freebsd-netbsd-openbsd > > "The project aims to support the most recent major version > at all times. Support for the previous major version will > be dropped 2 years after the new major version is released > or when the vendor itself drops support, whichever comes > first." > > IOW, we only aim for QEMU to be buildable on Ubuntu LTS 20.04 and 18.04 > at this point in time. 16.04 is explicitly dropped and we will increasingly > introduce incompatibilities with it. > > While this specific patch is simple, trying to keep QEMU git master > working on 16.04 is not a goal, so I'd really suggest upgrading to > a newer Ubuntu version at the soonest opportunity. In particular after 6.0 QEMU is released, we'll be dropping RHEL-7 and then likely setting the min required GCC to somewhere around 6.3 which will cut off Ubuntu 16.04 upfront. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|