From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3339FC433E0 for ; Wed, 10 Feb 2021 11:41:11 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D006664E42 for ; Wed, 10 Feb 2021 11:41:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D006664E42 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49220 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9nrp-0000tg-Qj for qemu-devel@archiver.kernel.org; Wed, 10 Feb 2021 06:41:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58784) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9nqI-0007yU-SA; Wed, 10 Feb 2021 06:39:34 -0500 Received: from mail-lf1-x133.google.com ([2a00:1450:4864:20::133]:45795) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l9nqC-0006bx-Uz; Wed, 10 Feb 2021 06:39:34 -0500 Received: by mail-lf1-x133.google.com with SMTP id j19so2265707lfr.12; Wed, 10 Feb 2021 03:39:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=pKIIXODYUHiXhhYdsdhw082kI/XvHKAZkUWlDjvH2Sc=; b=JEaT4Bp33XUl8FuqttUX5Kk7Bs8vMul2lv3jHIy0rhP1wSFqbV3GV8fLfiDs1E/Mhd TQhLJVHjA+cjuv7GKlaE/k3KjEuyGjT0VPBNfoOrbOEg0iEj0cJyHxxxlgTR+GroPQyC VeLsDJWlb36narGHVUdL9mHPpKzTJ4+/jI0bJHVL7p4q0JQJ3ONBSuNoEE0LUApLkGeg +AhzSbp8epn7orwZS3PkUahHo1g4Z8uOpNvnoidKTv1cC2lqTi35hQkGBSUpoZAtlA1M 7letWQAtGnNnc2yuY0szI0GGyNncyqMXcO+MWRPFyVbX8gqcWN5AequdecxRe71Lmb4C Mg3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pKIIXODYUHiXhhYdsdhw082kI/XvHKAZkUWlDjvH2Sc=; b=r3zmD0tJ7af4lsFh3LKDGIyPsoCuOpRW3pfxeLOED98bZGMpBcA9t2aV7ky1V6m3ZD BtkrvQ/kcFMyBojLXDFKL46obffrAgfeui05I+4ESpXua8jjr96y1CUYAgoh9MFmlbUp 0DDA+LaPb3Fdj3ivAEmV2vkvQWVsqNHRfk8OC4O2oiqMKfzxR6nVCisnhshZqrNAWoDO PKCCrrqy3sfZfPC2+tvClJQ6Vu9Dx863WYUjG0aOgzbACmvrp52kXkeGKE7jVPJYmCz6 NSzUBunG7yfSzsWeMaktQ4gtJoHAETPdJ+EQkXRWUx2qHYGyiEAM2puBknFwsaWzCJ7L ZhAg== X-Gm-Message-State: AOAM531XpOJc8bj0qLjlK2wDCBT9ttKKPvpCl6P2zWKlCnqVc+y7Lskl 3fJQp917Gx/QDHFSVUAryVA= X-Google-Smtp-Source: ABdhPJymi2uOWCN0XrcqbLZb+cy1iAAKR2CWtN0xoSi96z3mvbGR7h5tfmMik8aPeew6mIqaMcPEGw== X-Received: by 2002:ac2:4285:: with SMTP id m5mr1394621lfh.649.1612957166769; Wed, 10 Feb 2021 03:39:26 -0800 (PST) Received: from gmail.com (81-231-232-130-no39.tbcn.telia.com. [81.231.232.130]) by smtp.gmail.com with ESMTPSA id c11sm412047ljn.106.2021.02.10.03.39.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Feb 2021 03:39:26 -0800 (PST) Date: Wed, 10 Feb 2021 12:39:25 +0100 From: "Edgar E. Iglesias" To: Bin Meng Subject: Re: [PATCH v3 5/5] hw/ssi: xilinx_spips: Remove DMA related code from zynqmp_qspips Message-ID: <20210210113925.GL477672@toto> References: <1612951813-50542-1-git-send-email-bmeng.cn@gmail.com> <1612951813-50542-6-git-send-email-bmeng.cn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1612951813-50542-6-git-send-email-bmeng.cn@gmail.com> Received-SPF: pass client-ip=2a00:1450:4864:20::133; envelope-from=edgar.iglesias@gmail.com; helo=mail-lf1-x133.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Xuzhou Cheng , Bin Meng , qemu-devel@nongnu.org, Francisco Iglesias , qemu-arm@nongnu.org, Alistair Francis Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Feb 10, 2021 at 06:10:13PM +0800, Bin Meng wrote: > From: Xuzhou Cheng > > Now that the XLNX CSU DMA model is implemented, the existing codes > in the ZynqMP QSPIS are useless and should be removed. We should also modify XLNX_ZYNQMP_SPIPS_R_MAX in the header file. Otherwise, this looks good to me. > > Signed-off-by: Xuzhou Cheng > Signed-off-by: Bin Meng > > --- > > Changes in v3: > - new patch: xilinx_spips: Remove DMA related code from zynqmp_qspips > > hw/ssi/xilinx_spips.c | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c > index 8a0cc22..1e9dba2 100644 > --- a/hw/ssi/xilinx_spips.c > +++ b/hw/ssi/xilinx_spips.c > @@ -195,13 +195,6 @@ > #define R_GQSPI_MOD_ID (0x1fc / 4) > #define R_GQSPI_MOD_ID_RESET (0x10a0000) > > -#define R_QSPIDMA_DST_CTRL (0x80c / 4) > -#define R_QSPIDMA_DST_CTRL_RESET (0x803ffa00) > -#define R_QSPIDMA_DST_I_MASK (0x820 / 4) > -#define R_QSPIDMA_DST_I_MASK_RESET (0xfe) > -#define R_QSPIDMA_DST_CTRL2 (0x824 / 4) > -#define R_QSPIDMA_DST_CTRL2_RESET (0x081bfff8) > - > /* size of TXRX FIFOs */ > #define RXFF_A (128) > #define TXFF_A (128) > @@ -417,9 +410,6 @@ static void xlnx_zynqmp_qspips_reset(DeviceState *d) > s->regs[R_GQSPI_GPIO] = 1; > s->regs[R_GQSPI_LPBK_DLY_ADJ] = R_GQSPI_LPBK_DLY_ADJ_RESET; > s->regs[R_GQSPI_MOD_ID] = R_GQSPI_MOD_ID_RESET; > - s->regs[R_QSPIDMA_DST_CTRL] = R_QSPIDMA_DST_CTRL_RESET; > - s->regs[R_QSPIDMA_DST_I_MASK] = R_QSPIDMA_DST_I_MASK_RESET; > - s->regs[R_QSPIDMA_DST_CTRL2] = R_QSPIDMA_DST_CTRL2_RESET; > s->man_start_com_g = false; > s->gqspi_irqline = 0; > xlnx_zynqmp_qspips_update_ixr(s); > -- > 2.7.4 >