From: Minwoo Im <minwoo.im.dev@gmail.com>
To: qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: Keith Busch <kbusch@kernel.org>, Klaus Jensen <its@irrelevant.dk>,
Minwoo Im <minwoo.im.dev@gmail.com>,
Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>
Subject: [PATCH V2 0/6] hw/block/nvme: support namespace attachment
Date: Thu, 11 Feb 2021 01:09:30 +0900 [thread overview]
Message-ID: <20210210160937.1100-1-minwoo.im.dev@gmail.com> (raw)
Hello,
This series supports namespace attachment: attach and detach. This is
the second version series with a fix a bug on choosing a controller to
attach for a namespace in the attach command handler.
Since V1:
- Fix to take 'ctrl' which is given from the command rather than 'n'.
(Klaus)
- Add a [7/7] patch to support CNS 12h Identify command (Namespace
Attached Controller list).
This series has been tested with the following: (!CONFIG_NVME_MULTIPATH)
-device nvme-subsys,id=subsys0 \
-device nvme,serial=foo,id=nvme0,subsys=subsys0 \
-device nvme,serial=bar,id=nvme1,subsys=subsys0 \
-device nvme-ns,id=ns1,drive=drv0,nsid=1,subsys=subsys0,zoned=false \
-device nvme-ns,id=ns2,drive=drv1,nsid=2,subsys=subsys0,zoned=true \
-device nvme-ns,id=ns3,drive=drv2,nsid=3,subsys=subsys0,detached=true,zoned=false \
-device nvme-ns,id=ns4,drive=drv3,nsid=4,subsys=subsys0,detached=true,zoned=true \
root@vm:~/work# nvme list
Node SN Model Namespace Usage Format FW Rev
--------------------- -------------------- ---------------------------------------- --------- -------------------------- ---------------- --------
/dev/nvme0n1 foo QEMU NVMe Ctrl 1 268.44 MB / 268.44 MB 512 B + 0 B 1.0
/dev/nvme0n2 foo QEMU NVMe Ctrl 2 268.44 MB / 268.44 MB 512 B + 0 B 1.0
/dev/nvme1n1 bar QEMU NVMe Ctrl 1 268.44 MB / 268.44 MB 512 B + 0 B 1.0
/dev/nvme1n2 bar QEMU NVMe Ctrl 2 268.44 MB / 268.44 MB 512 B + 0 B 1.0
root@vm:~/work# nvme attach-ns /dev/nvme0 --namespace-id=3 --controllers=0,1
attach-ns: Success, nsid:3
root@vm:~/work# echo 1 > /sys/class/nvme/nvme0/rescan_controller
root@vm:~/work# echo 1 > /sys/class/nvme/nvme1/rescan_controller
root@vm:~/work# nvme list
Node SN Model Namespace Usage Format FW Rev
--------------------- -------------------- ---------------------------------------- --------- -------------------------- ---------------- --------
/dev/nvme0n1 foo QEMU NVMe Ctrl 1 268.44 MB / 268.44 MB 512 B + 0 B 1.0
/dev/nvme0n2 foo QEMU NVMe Ctrl 2 268.44 MB / 268.44 MB 512 B + 0 B 1.0
/dev/nvme0n3 foo QEMU NVMe Ctrl 3 268.44 MB / 268.44 MB 512 B + 0 B 1.0
/dev/nvme1n1 bar QEMU NVMe Ctrl 1 268.44 MB / 268.44 MB 512 B + 0 B 1.0
/dev/nvme1n2 bar QEMU NVMe Ctrl 2 268.44 MB / 268.44 MB 512 B + 0 B 1.0
/dev/nvme1n3 bar QEMU NVMe Ctrl 3 268.44 MB / 268.44 MB 512 B + 0 B 1.0
root@vm:~/work# nvme detach-ns /dev/nvme0 --namespace-id=3 --controllers=0
detach-ns: Success, nsid:3
root@vm:~/work# echo 1 > /sys/class/nvme/nvme0/rescan_controller
root@vm:~/work# nvme list
Node SN Model Namespace Usage Format FW Rev
--------------------- -------------------- ---------------------------------------- --------- -------------------------- ---------------- --------
/dev/nvme0n1 foo QEMU NVMe Ctrl 1 268.44 MB / 268.44 MB 512 B + 0 B 1.0
/dev/nvme0n2 foo QEMU NVMe Ctrl 2 268.44 MB / 268.44 MB 512 B + 0 B 1.0
/dev/nvme1n1 bar QEMU NVMe Ctrl 1 268.44 MB / 268.44 MB 512 B + 0 B 1.0
/dev/nvme1n2 bar QEMU NVMe Ctrl 2 268.44 MB / 268.44 MB 512 B + 0 B 1.0
/dev/nvme1n3 bar QEMU NVMe Ctrl 3 268.44 MB / 268.44 MB 512 B + 0 B 1.0
root@vm:~/work# nvme detach-ns /dev/nvme0 --namespace-id=1 --controllers=1
detach-ns: Success, nsid:1
root@vm:~/work# echo 1 > /sys/class/nvme/nvme1/rescan_controller
root@vm:~/work# nvme list
Node SN Model Namespace Usage Format FW Rev
--------------------- -------------------- ---------------------------------------- --------- -------------------------- ---------------- --------
/dev/nvme0n1 foo QEMU NVMe Ctrl 1 268.44 MB / 268.44 MB 512 B + 0 B 1.0
/dev/nvme0n2 foo QEMU NVMe Ctrl 2 268.44 MB / 268.44 MB 512 B + 0 B 1.0
/dev/nvme1n2 bar QEMU NVMe Ctrl 2 268.44 MB / 268.44 MB 512 B + 0 B 1.0
/dev/nvme1n3 bar QEMU NVMe Ctrl 3 268.44 MB / 268.44 MB 512 B + 0 B 1.0
root@vm:~/work# nvme attach-ns /dev/nvme0 --namespace-id=1 --controllers=1
attach-ns: Success, nsid:1
root@vm:~/work# echo 1 > /sys/class/nvme/nvme1/rescan_controller
root@vm:~/work# nvme list
Node SN Model Namespace Usage Format FW Rev
--------------------- -------------------- ---------------------------------------- --------- -------------------------- ---------------- --------
/dev/nvme0n1 foo QEMU NVMe Ctrl 1 268.44 MB / 268.44 MB 512 B + 0 B 1.0
/dev/nvme0n2 foo QEMU NVMe Ctrl 2 268.44 MB / 268.44 MB 512 B + 0 B 1.0
/dev/nvme1n1 bar QEMU NVMe Ctrl 1 268.44 MB / 268.44 MB 512 B + 0 B 1.0
/dev/nvme1n2 bar QEMU NVMe Ctrl 2 268.44 MB / 268.44 MB 512 B + 0 B 1.0
/dev/nvme1n3 bar QEMU NVMe Ctrl 3 268.44 MB / 268.44 MB 512 B + 0 B 1.0
Minwoo Im (7):
hw/block/nvme: support namespace detach
hw/block/nvme: fix namespaces array to 1-based
hw/block/nvme: fix allocated namespace list to 256
hw/block/nvme: support allocated namespace type
hw/block/nvme: refactor nvme_select_ns_iocs
hw/block/nvme: support namespace attachment command
hw/block/nvme: support Identify NS Attached Controller List
hw/block/nvme-ns.c | 1 +
hw/block/nvme-ns.h | 1 +
hw/block/nvme-subsys.h | 28 ++++-
hw/block/nvme.c | 241 +++++++++++++++++++++++++++++++++++------
hw/block/nvme.h | 33 ++++++
hw/block/trace-events | 3 +
include/block/nvme.h | 6 +
7 files changed, 278 insertions(+), 35 deletions(-)
--
2.17.1
next reply other threads:[~2021-02-10 16:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 16:09 Minwoo Im [this message]
2021-02-10 16:09 ` [PATCH V2 1/7] hw/block/nvme: support namespace detach Minwoo Im
2021-02-10 16:09 ` [PATCH V2 2/7] hw/block/nvme: fix namespaces array to 1-based Minwoo Im
2021-02-10 16:09 ` [PATCH V2 3/7] hw/block/nvme: fix allocated namespace list to 256 Minwoo Im
2021-02-10 16:09 ` [PATCH V2 4/7] hw/block/nvme: support allocated namespace type Minwoo Im
2021-02-10 16:09 ` [PATCH V2 5/7] hw/block/nvme: refactor nvme_select_ns_iocs Minwoo Im
2021-02-10 16:09 ` [PATCH V2 6/7] hw/block/nvme: support namespace attachment command Minwoo Im
2021-02-22 20:43 ` Klaus Jensen
2021-02-26 17:59 ` Keith Busch
2021-02-27 1:01 ` Minwoo Im
2021-02-10 16:09 ` [PATCH V2 7/7] hw/block/nvme: support Identify NS Attached Controller List Minwoo Im
2021-02-22 20:53 ` [PATCH V2 0/6] hw/block/nvme: support namespace attachment Klaus Jensen
2021-02-26 13:14 ` Minwoo Im
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210210160937.1100-1-minwoo.im.dev@gmail.com \
--to=minwoo.im.dev@gmail.com \
--cc=its@irrelevant.dk \
--cc=kbusch@kernel.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).