From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33C11C433E0 for ; Wed, 10 Feb 2021 17:33:57 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CC14C64EC9 for ; Wed, 10 Feb 2021 17:33:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CC14C64EC9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50792 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9tNA-000450-C9 for qemu-devel@archiver.kernel.org; Wed, 10 Feb 2021 12:33:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53494) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9tGm-0005X2-4H for qemu-devel@nongnu.org; Wed, 10 Feb 2021 12:27:16 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:57937) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l9tGg-0004FW-7d for qemu-devel@nongnu.org; Wed, 10 Feb 2021 12:27:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612978028; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EB5PCb4AvxpQOsw2yjrjuWP9OFyUUkwvq3aRTnhFnNY=; b=GQj0qRLkcy09qSrk8irKnhWBcnYzTFz4CjrM/iO2S/iOhMXbXWAZP1aEjZ3zQSGIT/FHf7 0pbBc3e0VyZpt6CgvGMZ/XrtNvek0JbnBRXCh/kh/eyrBvLzx1XTJZDDCMwuTWC1gmg1f9 K9q8BLoLSODPNfgcwTKCYIFTfAkviu0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-522-5BKfWhqUM16kUuTxBRks6A-1; Wed, 10 Feb 2021 12:27:04 -0500 X-MC-Unique: 5BKfWhqUM16kUuTxBRks6A-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 25626107ACE4; Wed, 10 Feb 2021 17:27:03 +0000 (UTC) Received: from merkur.fritz.box (ovpn-115-33.ams2.redhat.com [10.36.115.33]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8F48718AA1; Wed, 10 Feb 2021 17:26:59 +0000 (UTC) Date: Wed, 10 Feb 2021 18:26:57 +0100 From: Kevin Wolf To: Alberto Garcia Subject: Re: [RFC PATCH v2 0/4] Allow changing bs->file on reopen Message-ID: <20210210172657.GJ5144@merkur.fritz.box> References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kwolf@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=63.128.21.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -33 X-Spam_score: -3.4 X-Spam_bar: --- X-Spam_report: (-3.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.568, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vladimir Sementsov-Ogievskiy , pkrempa@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Am 08.02.2021 um 19:44 hat Alberto Garcia geschrieben: > Hi, > > this series allows changing bs->file using x-blockdev-reopen. Read > here for more details: > > https://lists.gnu.org/archive/html/qemu-block/2021-01/msg00437.html > > Version 2 of the series introduces a very significant change: > x-blockdev-reopen now receives a list of BlockdevOptions instead of > just one, so it is possible to reopen multiple block devices using a > single transaction. Adding Peter to Cc for this one. > This is still an RFC, I haven't updated the documentation and the > structure of the patches will probably change in the future, but I'd > like to know your opinion about the approach. I like the direction where this is going. You have a test case for adding a throttling filter. Can we also remove it again or is there still a problem with that? I seem to remember that that was a bit trickier, though I'm not sure what it was. Was it that we can't have the throttle node without a file, so it would possibly still have permission conflicts? Kevin