From: Minwoo Im <minwoo.im.dev@gmail.com>
To: Klaus Jensen <its@irrelevant.dk>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org,
Max Reitz <mreitz@redhat.com>, Keith Busch <kbusch@kernel.org>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [RFC PATCH 1/3] hw/block/nvme: set NVME_DNR in a single place
Date: Thu, 11 Feb 2021 12:40:19 +0900 [thread overview]
Message-ID: <20210211034019.GF24885@localhost.localdomain> (raw)
In-Reply-To: <YCQ/38kzPxdWDPqG@apples.localdomain>
On 21-02-10 21:19:43, Klaus Jensen wrote:
> On Feb 11 04:52, Minwoo Im wrote:
> > @@ -945,6 +945,11 @@ static void nvme_post_cqes(void *opaque)
> > static void nvme_enqueue_req_completion(NvmeCQueue *cq, NvmeRequest *req)
> > {
> > assert(cq->cqid == req->sq->cqid);
> > +
> > + if (req->status != NVME_SUCCESS) {
> > + req->status |= NVME_DNR;
> > + }
>
> There are status codes where we do not set the DNR bit (e.g. Data
> Transfer Error, and that might be the only one actually).
Ouch, I think I need to prepare some of switch-helper to figure out
which one needs to be retried or not.
> Maybe a switch such that we do not explicitly set DNR for Data Transfer
> Error (and any other errors we identify), but only if we set it earlier
> in the stack.
Agreed.
next prev parent reply other threads:[~2021-02-11 3:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 19:52 [RFC PATCH 0/3] support command retry Minwoo Im
2021-02-10 19:52 ` [RFC PATCH 1/3] hw/block/nvme: set NVME_DNR in a single place Minwoo Im
2021-02-10 20:19 ` Klaus Jensen
2021-02-11 3:40 ` Minwoo Im [this message]
2021-02-10 19:52 ` [RFC PATCH 2/3] hw/block/nvme: support command retry delay Minwoo Im
2021-02-10 20:37 ` Klaus Jensen
2021-02-10 19:52 ` [RFC PATCH 3/3] hw/block/nvme: add nvme_inject_state HMP command Minwoo Im
2021-02-10 20:33 ` Klaus Jensen
2021-02-11 3:23 ` Minwoo Im
2021-02-11 10:02 ` Dr. David Alan Gilbert
2021-02-11 3:00 ` Keith Busch
2021-02-11 3:38 ` Minwoo Im
2021-02-11 4:24 ` Keith Busch
2021-02-11 4:40 ` Warner Losh
2021-02-11 6:06 ` Minwoo Im
2021-02-11 7:26 ` Klaus Jensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210211034019.GF24885@localhost.localdomain \
--to=minwoo.im.dev@gmail.com \
--cc=dgilbert@redhat.com \
--cc=its@irrelevant.dk \
--cc=kbusch@kernel.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).