qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org
Cc: vsementsov@virtuozzo.com, berrange@redhat.com,
	qemu-block@nongnu.org, tao3.xu@intel.com, rjones@redhat.com,
	armbru@redhat.com
Subject: [PATCH v2 0/4] improve do_strtosz precision
Date: Thu, 11 Feb 2021 14:44:34 -0600	[thread overview]
Message-ID: <20210211204438.1184395-1-eblake@redhat.com> (raw)

Parsing sizes with only 53 bits of precision is surprising; it's time
to fix it to use a full 64 bits of precision.

v1 was here:
https://lists.gnu.org/archive/html/qemu-devel/2021-02/msg01800.html

Since then:
- split testsuite improvements from code changes [Vladimir]
- more tests for more corner cases [Vladimir, Rich, Dan]
- fix handling of '123-45' when endptr is non-NULL [Vladimir]
- fix handling of '1.k'
- actually enable deprecation of '0x1k' [Vladimir]
- include missing deprecation text for rounded fractions
- improved commit messages

I'm still not sure I like patch 4, but it's at least worth considering.

Eric Blake (4):
  utils: Enhance testsuite for do_strtosz()
  utils: Improve qemu_strtosz() to have 64 bits of precision
  utils: Deprecate hex-with-suffix sizes
  utils: Deprecate inexact fractional suffix sizes

 docs/system/deprecated.rst       |  17 ++++
 tests/test-cutils.c              | 168 ++++++++++++++++++++++++++-----
 tests/test-keyval.c              |  39 ++++---
 tests/test-qemu-opts.c           |  37 ++++---
 util/cutils.c                    | 103 +++++++++++++++----
 tests/qemu-iotests/049.out       |  14 ++-
 tests/qemu-iotests/178.out.qcow2 |   3 +-
 tests/qemu-iotests/178.out.raw   |   3 +-
 8 files changed, 305 insertions(+), 79 deletions(-)

-- 
2.30.1



             reply	other threads:[~2021-02-11 20:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-11 20:44 Eric Blake [this message]
2021-02-11 20:44 ` [PATCH v2 1/4] utils: Enhance testsuite for do_strtosz() Eric Blake
2021-02-23 17:07   ` Daniel P. Berrangé
2021-02-11 20:44 ` [PATCH v2 2/4] utils: Improve qemu_strtosz() to have 64 bits of precision Eric Blake
2021-02-23 17:13   ` Daniel P. Berrangé
2021-02-11 20:44 ` [PATCH v2 3/4] utils: Deprecate hex-with-suffix sizes Eric Blake
2021-02-11 22:59   ` Philippe Mathieu-Daudé
2021-02-23 17:13   ` Daniel P. Berrangé
2021-02-11 20:44 ` [PATCH v2 4/4] utils: Deprecate inexact fractional suffix sizes Eric Blake
2021-02-23 17:20   ` Daniel P. Berrangé
2021-02-24 13:52     ` Eric Blake
2021-02-22 20:19 ` [PATCH v2 0/4] improve do_strtosz precision Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210211204438.1184395-1-eblake@redhat.com \
    --to=eblake@redhat.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rjones@redhat.com \
    --cc=tao3.xu@intel.com \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).