From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3CA1C433DB for ; Fri, 12 Feb 2021 03:07:46 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 596AC64E2A for ; Fri, 12 Feb 2021 03:07:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 596AC64E2A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55140 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lAOo5-000402-CI for qemu-devel@archiver.kernel.org; Thu, 11 Feb 2021 22:07:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54326) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lAOmu-0003W4-87 for qemu-devel@nongnu.org; Thu, 11 Feb 2021 22:06:32 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:59221) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lAOmr-00054m-TT for qemu-devel@nongnu.org; Thu, 11 Feb 2021 22:06:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613099188; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cv8OOUX/cHdl3SlyZ7qqT9a6mdVWa1hBF27lpPE4bwY=; b=CL9uZQFbjozpub52aXHsz8fvzZ2/woKrncTGeZ51ehJ+qHWHB9ntlW25+B0Mqy3k51Oh4Y SMQtmAHqm5EAut780z2rdcGxRUb7/ZEQ38RHWOTAqQkD1RnZeRLrCoxwSl7cHMGLN0CfzC oRwmpeTc4z6E26Ho4/SOcLPhzZQBkT8= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-244-LjgZWOglOBiVpvCJCjHw9Q-1; Thu, 11 Feb 2021 22:06:24 -0500 X-MC-Unique: LjgZWOglOBiVpvCJCjHw9Q-1 Received: by mail-qk1-f198.google.com with SMTP id f16so6282129qke.0 for ; Thu, 11 Feb 2021 19:06:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=cv8OOUX/cHdl3SlyZ7qqT9a6mdVWa1hBF27lpPE4bwY=; b=LfnRwqL2OvOjOaeRp5XrtPKkMHW7WRfNEsIm60D7SEWrVirUuGa165en2AIXkpBJYR Jc8Bk66XvAHIEqfrLDdwE3iTNdKTH326PL6YC156Krmo0wuF5vOCQJA1UerV6XHGVz4N wid2QNTE5yrALOOWV1YQLDzNTCpXoCF6qEAcmYKQSpWSoqeU4JLPsG9lBq5bZvs4J6to M0M5HLtsKvVLFv0O410E7O2b9BoTQzujaUmigaezqmdBKdFIxFSh3+sPMRTrIZKY6Hz0 M13BwhJnA+NvsnSMDDEUew4RsScg06TM6w5dV3B34JgeK1xE28hoRho3893ULB4/3Lic K53w== X-Gm-Message-State: AOAM531HVc0sGegmwh6T9omoWhdQBe2tEg4MzDoQvZg4xhnEri7aBMX3 Q/kPFfGmGuDwXSeiZpxWzrqn2th5Nq3dB509CVZc527YeFsOvuTcG8LJgGiid+ObJP6F+1BwX1O fRyjp8/b+ulqvuWw= X-Received: by 2002:ad4:448e:: with SMTP id m14mr760540qvt.35.1613099184090; Thu, 11 Feb 2021 19:06:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJyh8irOL7MIqfIp/RoNRpMFOONkqDoYBVwLKjrYIccm5fC5aLXq74qltq9DjiIsKowouCa3YA== X-Received: by 2002:ad4:448e:: with SMTP id m14mr760525qvt.35.1613099183855; Thu, 11 Feb 2021 19:06:23 -0800 (PST) Received: from xz-x1 (bras-vprn-toroon474qw-lp130-20-174-93-89-182.dsl.bell.ca. [174.93.89.182]) by smtp.gmail.com with ESMTPSA id o17sm4980875qtl.47.2021.02.11.19.06.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Feb 2021 19:06:23 -0800 (PST) Date: Thu, 11 Feb 2021 22:06:21 -0500 From: Peter Xu To: David Hildenbrand Subject: Re: [PATCH v13 0/5] UFFD write-tracking migration/snapshots Message-ID: <20210212030621.GF157159@xz-x1> References: <20210211210549.GE157159@xz-x1> <4E588B57-AAC8-40DD-9260-541836074DB3@redhat.com> MIME-Version: 1.0 In-Reply-To: <4E588B57-AAC8-40DD-9260-541836074DB3@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=peterx@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=peterx@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -33 X-Spam_score: -3.4 X-Spam_bar: --- X-Spam_report: (-3.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.569, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Juan Quintela , qemu-devel@nongnu.org, "Michael S. Tsirkin" , Markus Armbruster , Alexander Duyck , "Dr . David Alan Gilbert" , Den Lunev , Paolo Bonzini , Andrey Gruzdev Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Feb 11, 2021 at 10:09:58PM +0100, David Hildenbrand wrote: > The issue is when the discard happened before starting the snapshot. Write-protection won‘t work and the zeroed content won‘t be retained in the snapshot. I see what you mean now, and iiuc it will only be a problem if init_on_free=1. I think CONFIG_INIT_ON_FREE_DEFAULT_ON should be off for most distros, so the impact should be small, I think. I thought about it, but indeed I didn't see a good way to fix this if without fixing the zero page copy for live snapshot. -- Peter Xu