From: Max Reitz <mreitz@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Cleber Rosa" <crosa@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Max Reitz" <mreitz@redhat.com>
Subject: [PATCH] virtiofs_submounts.py test: Note on vmlinuz param
Date: Fri, 12 Feb 2021 16:16:49 +0100 [thread overview]
Message-ID: <20210212151649.252440-1-mreitz@redhat.com> (raw)
From the cancel message, it is not entirely clear why this parameter is
mandatory now, or that it will be optional in the future. Add such a
more detailed explanation as a comment in the test source file.
Suggested-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Max Reitz <mreitz@redhat.com>
---
I’ve uploaded a build of Linux 5.10 here:
https://xanclic.moe/linux-5.10
But I’ve decided against mentioning it in this new comment or the cancel
message, because, well, it’s my private server and I have limited
bandwidth.
---
tests/acceptance/virtiofs_submounts.py | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/tests/acceptance/virtiofs_submounts.py b/tests/acceptance/virtiofs_submounts.py
index 949ca87a83..9a69b6b17b 100644
--- a/tests/acceptance/virtiofs_submounts.py
+++ b/tests/acceptance/virtiofs_submounts.py
@@ -228,6 +228,18 @@ class VirtiofsSubmountsTest(BootLinux):
def setUp(self):
vmlinuz = self.params.get('vmlinuz')
if vmlinuz is None:
+ """
+ The Linux kernel supports FUSE auto-submounts only as of 5.10.
+ boot_linux.py currently provides Fedora 31, whose kernel is too
+ old, so this test cannot pass with the on-image kernel (you are
+ welcome to try, hence the option to force such a test with
+ -p vmlinuz=''). Therefore, for now the user must provide a
+ sufficiently new custom kernel, or effectively explicitly
+ request failure with -p vmlinuz=''.
+ Once an image with a sufficiently new kernel is available
+ (probably Fedora 34), we can make -p vmlinuz='' the default, so
+ that this parameter no longer needs to be specified.
+ """
self.cancel('vmlinuz parameter not set; you must point it to a '
'Linux kernel binary to test (to run this test with ' \
'the on-image kernel, set it to an empty string)')
--
2.29.2
next reply other threads:[~2021-02-12 15:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-12 15:16 Max Reitz [this message]
2021-02-12 18:58 ` [PATCH] virtiofs_submounts.py test: Note on vmlinuz param Cleber Rosa
2021-02-12 20:42 ` Philippe Mathieu-Daudé
2021-02-16 0:06 ` Cleber Rosa
2021-02-18 16:24 ` Max Reitz
2021-02-12 20:58 ` Willian Rampazzo
2021-02-12 22:00 ` Alex Bennée
2021-02-16 0:00 ` Cleber Rosa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210212151649.252440-1-mreitz@redhat.com \
--to=mreitz@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=crosa@redhat.com \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).