From: Gerd Hoffmann <kraxel@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: can surface_bits_per_pixel() for the console surface ever return anything other than 32 ?
Date: Mon, 15 Feb 2021 10:01:36 +0100 [thread overview]
Message-ID: <20210215090136.e6iyhiluc36r6xbu@sirius.home.kraxel.org> (raw)
In-Reply-To: <CAFEAcA9E-HpCv91DmBoxi2dZjXY0Nsy58dxUQ5HGFki4YK5uaw@mail.gmail.com>
On Fri, Feb 12, 2021 at 06:38:16PM +0000, Peter Maydell wrote:
> On Thu, 11 Feb 2021 at 10:12, Gerd Hoffmann <kraxel@redhat.com> wrote:
> >
> > Hi,
> >
> > > I notice that as well as handling surface_bits_per_pixel()
> > > possibly returning 8, 15, 16, 24, these devices also seem to
> > > check for the possibility it returns 0 (presumably meaning
> > > "no surface" or "no surface yet" ?).
> >
> > Depends a bit on how the surface is created.
> >
> > When using host memory as backing storage (typical workflow is
> > qemu_console_resize() + qemu_console_surface() calls) bits per pixel is
> > 32 no matter what (format is PIXMAN_x8r8g8b8 to be exact). I think this
> > is true for most if not all arm display devices.
>
> Quick follow-up check: this is always RGB, ie is_surface_bgr()
> will always return false, right ?
Yes, always rgb (in host native byte order).
take care,
Gerd
prev parent reply other threads:[~2021-02-15 9:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 18:02 can surface_bits_per_pixel() for the console surface ever return anything other than 32 ? Peter Maydell
2021-02-11 10:12 ` Gerd Hoffmann
2021-02-11 10:51 ` Peter Maydell
2021-02-12 18:38 ` Peter Maydell
2021-02-15 9:01 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210215090136.e6iyhiluc36r6xbu@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).