qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: "Andreas K . Hüttel" <dilfridge@gentoo.org>,
	"Alistair Francis" <alistair.francis@wdc.com>,
	"Laurent Vivier" <laurent@vivier.eu>
Subject: [PULL 03/13] linux-user/signal: Decode waitid si_code
Date: Mon, 15 Feb 2021 13:45:09 +0100	[thread overview]
Message-ID: <20210215124519.720265-4-laurent@vivier.eu> (raw)
In-Reply-To: <20210215124519.720265-1-laurent@vivier.eu>

From: Alistair Francis <alistair.francis@wdc.com>

When mapping the host waitid status to the target status we previously
just used decoding information in the status value. This doesn't follow
what the waitid documentation describes, which instead suggests using
the si_code value for the decoding. This results in the incorrect values
seen when calling waitid. This is especially apparent on RV32 where all
wait calls use waitid (see the bug case).

This patch just passes the waitid status directly back to the guest.

Buglink: https://bugs.launchpad.net/qemu/+bug/1906193
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Tested-by: Andreas K. Hüttel <dilfridge@gentoo.org>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <1fb2d56aa23a81f4473e638abe9e2d78c09a3d5b.1611080607.git.alistair.francis@wdc.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
 linux-user/signal.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/linux-user/signal.c b/linux-user/signal.c
index 73de934c6511..7eecec46c407 100644
--- a/linux-user/signal.c
+++ b/linux-user/signal.c
@@ -349,8 +349,7 @@ static inline void host_to_target_siginfo_noswap(target_siginfo_t *tinfo,
         case TARGET_SIGCHLD:
             tinfo->_sifields._sigchld._pid = info->si_pid;
             tinfo->_sifields._sigchld._uid = info->si_uid;
-            tinfo->_sifields._sigchld._status
-                = host_to_target_waitstatus(info->si_status);
+            tinfo->_sifields._sigchld._status = info->si_status;
             tinfo->_sifields._sigchld._utime = info->si_utime;
             tinfo->_sifields._sigchld._stime = info->si_stime;
             si_type = QEMU_SI_CHLD;
-- 
2.29.2



  parent reply	other threads:[~2021-02-15 12:52 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-15 12:45 [PULL 00/13] Linux user for 6.0 patches Laurent Vivier
2021-02-15 12:45 ` [PULL 01/13] linux-user/mips64: Restore setup_frame() for o32 ABI Laurent Vivier
2021-02-15 12:45 ` [PULL 02/13] linux-user/mips64: Support o32 ABI syscalls Laurent Vivier
2021-02-15 12:45 ` Laurent Vivier [this message]
2021-02-15 12:45 ` [PULL 04/13] linux-user: Add missing TARGET___O_TMPFILE for hppa and alpha Laurent Vivier
2021-02-15 12:45 ` [PULL 05/13] linux-user: fix O_NONBLOCK usage for hppa target Laurent Vivier
2021-02-15 12:45 ` [PULL 06/13] linux-user: fix O_NONBLOCK in signalfd4() and eventfd2() syscalls Laurent Vivier
2021-02-15 12:45 ` [PULL 07/13] linux-user: Fix loading of BSS segments Laurent Vivier
2021-02-15 12:45 ` [PULL 08/13] linux-user/mmap: Avoid asserts for out of range mremap calls Laurent Vivier
2021-02-15 12:45 ` [PULL 09/13] linux-user/syscall: Fix do_ioctl_ifconf() for 64 bit targets Laurent Vivier
2021-02-15 12:45 ` [PULL 10/13] linux-user: add TARGET_SO_{DOMAIN,PROTOCOL} Laurent Vivier
2021-02-15 12:45 ` [PULL 11/13] linux-user: target: signal: Support TARGET_SS_AUTODISARM Laurent Vivier
2021-02-15 12:45 ` [PULL 12/13] docs/user: Remove outdated 'Quick Start' section Laurent Vivier
2021-02-15 12:45 ` [PULL 13/13] linux-user/mips: Support the n32 ABI for the R5900 Laurent Vivier
2021-02-15 13:40 ` [PULL 00/13] Linux user for 6.0 patches Philippe Mathieu-Daudé
2021-02-15 14:15   ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210215124519.720265-4-laurent@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=alistair.francis@wdc.com \
    --cc=dilfridge@gentoo.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).