From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: Helge Deller <deller@gmx.de>, Laurent Vivier <laurent@vivier.eu>
Subject: [PULL 05/13] linux-user: fix O_NONBLOCK usage for hppa target
Date: Mon, 15 Feb 2021 13:45:11 +0100 [thread overview]
Message-ID: <20210215124519.720265-6-laurent@vivier.eu> (raw)
In-Reply-To: <20210215124519.720265-1-laurent@vivier.eu>
From: Helge Deller <deller@gmx.de>
Historically the parisc linux port tried to be compatible with HP-UX
userspace and as such defined the O_NONBLOCK constant to 0200004 to
emulate separate NDELAY & NONBLOCK values.
Since parisc was the only Linux platform which had two bits set, this
produced various userspace issues. Finally it was decided to drop the
(never completed) HP-UX compatibilty, which is why O_NONBLOCK was
changed upstream to only have one bit set in future with this commit:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=75ae04206a4d0e4f541c1d692b7febd1c0fdb814
This patch simply adjusts the value for qemu-user too.
Signed-off-by: Helge Deller <deller@gmx.de>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <20210201220551.GA8015@ls3530.fritz.box>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
linux-user/hppa/target_fcntl.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/linux-user/hppa/target_fcntl.h b/linux-user/hppa/target_fcntl.h
index 9eaeef9d8e7b..08e3a4fcb0b7 100644
--- a/linux-user/hppa/target_fcntl.h
+++ b/linux-user/hppa/target_fcntl.h
@@ -8,7 +8,7 @@
#ifndef HPPA_TARGET_FCNTL_H
#define HPPA_TARGET_FCNTL_H
-#define TARGET_O_NONBLOCK 000200004 /* HPUX has separate NDELAY & NONBLOCK */
+#define TARGET_O_NONBLOCK 000200000
#define TARGET_O_APPEND 000000010
#define TARGET_O_CREAT 000000400 /* not fcntl */
#define TARGET_O_EXCL 000002000 /* not fcntl */
--
2.29.2
next prev parent reply other threads:[~2021-02-15 12:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-15 12:45 [PULL 00/13] Linux user for 6.0 patches Laurent Vivier
2021-02-15 12:45 ` [PULL 01/13] linux-user/mips64: Restore setup_frame() for o32 ABI Laurent Vivier
2021-02-15 12:45 ` [PULL 02/13] linux-user/mips64: Support o32 ABI syscalls Laurent Vivier
2021-02-15 12:45 ` [PULL 03/13] linux-user/signal: Decode waitid si_code Laurent Vivier
2021-02-15 12:45 ` [PULL 04/13] linux-user: Add missing TARGET___O_TMPFILE for hppa and alpha Laurent Vivier
2021-02-15 12:45 ` Laurent Vivier [this message]
2021-02-15 12:45 ` [PULL 06/13] linux-user: fix O_NONBLOCK in signalfd4() and eventfd2() syscalls Laurent Vivier
2021-02-15 12:45 ` [PULL 07/13] linux-user: Fix loading of BSS segments Laurent Vivier
2021-02-15 12:45 ` [PULL 08/13] linux-user/mmap: Avoid asserts for out of range mremap calls Laurent Vivier
2021-02-15 12:45 ` [PULL 09/13] linux-user/syscall: Fix do_ioctl_ifconf() for 64 bit targets Laurent Vivier
2021-02-15 12:45 ` [PULL 10/13] linux-user: add TARGET_SO_{DOMAIN,PROTOCOL} Laurent Vivier
2021-02-15 12:45 ` [PULL 11/13] linux-user: target: signal: Support TARGET_SS_AUTODISARM Laurent Vivier
2021-02-15 12:45 ` [PULL 12/13] docs/user: Remove outdated 'Quick Start' section Laurent Vivier
2021-02-15 12:45 ` [PULL 13/13] linux-user/mips: Support the n32 ABI for the R5900 Laurent Vivier
2021-02-15 13:40 ` [PULL 00/13] Linux user for 6.0 patches Philippe Mathieu-Daudé
2021-02-15 14:15 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210215124519.720265-6-laurent@vivier.eu \
--to=laurent@vivier.eu \
--cc=deller@gmx.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).