From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BDA7C433E0 for ; Mon, 15 Feb 2021 14:00:00 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EFAAD600CF for ; Mon, 15 Feb 2021 13:59:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EFAAD600CF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40664 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lBePv-0005DO-4P for qemu-devel@archiver.kernel.org; Mon, 15 Feb 2021 08:59:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40612) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lBeOr-0004kP-NZ for qemu-devel@nongnu.org; Mon, 15 Feb 2021 08:58:53 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:54946) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lBeOp-0006Zf-1c for qemu-devel@nongnu.org; Mon, 15 Feb 2021 08:58:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613397529; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/N8SoVWcwHNYR+ysXTU4+OoQwG/w3OP6LUw9kNlIH0w=; b=ZJzzz+OpWSfElzABILEInj7R6oqV2zXNdusge6wKahBzjoZ7RHCZyi5JR63Hpvu0ofkzka Yn+j11Ds+fRV6FXnO3RzInkpBcErcdqg9E4IOGRrex4gZej28X9bdz+rNq5hT6hjc37/oT VITCBgIuuWDs/vuasiNC8Q2qyGkmw/c= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-387-KScqHIhBN3apwHXfBrfJhw-1; Mon, 15 Feb 2021 08:58:47 -0500 X-MC-Unique: KScqHIhBN3apwHXfBrfJhw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7C6AA10074B2 for ; Mon, 15 Feb 2021 13:58:46 +0000 (UTC) Received: from merkur.fritz.box (ovpn-113-28.ams2.redhat.com [10.36.113.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B4D605C241; Mon, 15 Feb 2021 13:58:45 +0000 (UTC) Date: Mon, 15 Feb 2021 14:58:44 +0100 From: Kevin Wolf To: Markus Armbruster Subject: Re: [PATCH 2/2] monitor/qmp: Stop processing requests when shutdown is requested Message-ID: <20210215135844.GP7226@merkur.fritz.box> References: <20210212172028.288825-1-kwolf@redhat.com> <20210212172028.288825-3-kwolf@redhat.com> <87blclzg4p.fsf@dusky.pond.sub.org> <20210215122819.GL7226@merkur.fritz.box> <87k0r9y01g.fsf@dusky.pond.sub.org> MIME-Version: 1.0 In-Reply-To: <87k0r9y01g.fsf@dusky.pond.sub.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kwolf@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Am 15.02.2021 um 13:42 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 15.02.2021 um 13:09 hat Markus Armbruster geschrieben: > >> Kevin Wolf writes: > >> > >> > monitor_qmp_dispatcher_co() used to check whether shutdown is requested > >> > >> "used to": until when? > > > > Until right before this patch. Do you prefer present tense to describe > > the old state? > > I've done it both ways. I think present tense works better for me. > Case in point: I wasn't confident I read your commit message correctly, > so I asked. I guess I can just add "Before this patch, ..." to clarify. > > Also, does your Tested-by imply that you expect someone else to merge > > this series? I'm planning to send a pull request today, so if that was > > your intention, I can include it there. > > I didn't mean to imply anything beyond "I ran my reproducer, and your > patches fix it." > > I don't mind you including the fixes in your pull request. I also > don't mind doing a pull request for your fixes. Up to you! Ok, if you don't mind either way, I'll just fix up the commit message and include it. I just asked because it has happened before that everyone was waiting for someone else to merge a patch. So I made it a habit to ask when a maintainer replies with some kind of approval without mentioning that they queued the patch, because that could be a sign that they expect it to go through a different tree. Kevin