From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, peter.maydell@linaro.org, qemu-devel@nongnu.org
Subject: [PULL 07/11] crypto: luks: Fix tiny memory leak
Date: Mon, 15 Feb 2021 16:00:56 +0100 [thread overview]
Message-ID: <20210215150100.436555-8-kwolf@redhat.com> (raw)
In-Reply-To: <20210215150100.436555-1-kwolf@redhat.com>
From: Maxim Levitsky <mlevitsk@redhat.com>
When the underlying block device doesn't support the
bdrv_co_delete_file interface, an 'Error' object was leaked.
Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20201217170904.946013-2-mlevitsk@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
block/crypto.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/block/crypto.c b/block/crypto.c
index aef5a5721a..b3a5275132 100644
--- a/block/crypto.c
+++ b/block/crypto.c
@@ -735,6 +735,8 @@ fail:
*/
if ((r_del < 0) && (r_del != -ENOTSUP)) {
error_report_err(local_delete_err);
+ } else {
+ error_free(local_delete_err);
}
}
--
2.29.2
next prev parent reply other threads:[~2021-02-15 15:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-15 15:00 [PULL 00/11] Block layer patches Kevin Wolf
2021-02-15 15:00 ` [PULL 01/11] qemu-storage-daemon: Enable object-add Kevin Wolf
2021-02-15 15:00 ` [PULL 02/11] iotests: Consistent $IMGOPTS boundary matching Kevin Wolf
2021-02-15 15:00 ` [PULL 03/11] blockjob: Fix crash with IOthread when block commit after snapshot Kevin Wolf
2021-02-15 15:00 ` [PULL 04/11] hw/ide/ahci: map cmd_fis as DMA_DIRECTION_TO_DEVICE Kevin Wolf
2021-02-15 15:00 ` [PULL 05/11] xen-block: fix reporting of discard feature Kevin Wolf
2021-02-15 15:00 ` [PULL 06/11] tests/qemu-iotests: Remove test 259 from the "auto" group Kevin Wolf
2021-02-15 15:00 ` Kevin Wolf [this message]
2021-02-15 15:00 ` [PULL 08/11] block: add bdrv_co_delete_file_noerr Kevin Wolf
2021-02-15 15:00 ` [PULL 09/11] block: qcow2: remove the created file on initialization error Kevin Wolf
2021-02-15 15:00 ` [PULL 10/11] monitor: Fix assertion failure on shutdown Kevin Wolf
2021-02-15 15:01 ` [PULL 11/11] monitor/qmp: Stop processing requests when shutdown is requested Kevin Wolf
2021-02-15 19:57 ` [PULL 00/11] Block layer patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210215150100.436555-8-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).