From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9421C433E0 for ; Mon, 15 Feb 2021 17:11:54 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2E4CE64DC3 for ; Mon, 15 Feb 2021 17:11:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2E4CE64DC3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33922 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lBhPd-0002Rh-91 for qemu-devel@archiver.kernel.org; Mon, 15 Feb 2021 12:11:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60074) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lBhN5-000829-Dd for qemu-devel@nongnu.org; Mon, 15 Feb 2021 12:09:15 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:33059) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lBhN2-0007Cg-Ds for qemu-devel@nongnu.org; Mon, 15 Feb 2021 12:09:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613408951; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ONiiVivyNDQKM6BqIPiIZlUdD0ajeL26DacmE18Eeiw=; b=AxE9Y4+7AScCDOSgYEU0CYHL08axWXXIi/gCSgq4F2LbJki/dUz/G1NEWHRP2HSA+8wtqK R/6i0aU8u2itKKrrFV5BJJSQBIvG7lriCmqiNhtUpOVI+qAzZ747NlsNaOzS1s41Lp/iCy 0NO47QBYH1ar1FkLLzVa30raS268mRE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-53-D2rriB1jNb-IwfV9f4oiYA-1; Mon, 15 Feb 2021 12:09:09 -0500 X-MC-Unique: D2rriB1jNb-IwfV9f4oiYA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 586D96DD28; Mon, 15 Feb 2021 17:09:08 +0000 (UTC) Received: from merkur.fritz.box (ovpn-113-28.ams2.redhat.com [10.36.113.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DA58660BE2; Mon, 15 Feb 2021 17:09:04 +0000 (UTC) Date: Mon, 15 Feb 2021 18:09:02 +0100 From: Kevin Wolf To: Eric Blake Subject: Re: [PULL 3/5] qemu-iotests: 300: Add test case for modifying persistence of bitmap Message-ID: <20210215170902.GS7226@merkur.fritz.box> References: <20210212232134.1462756-1-eblake@redhat.com> <20210212232134.1462756-4-eblake@redhat.com> <20210215123152.GM7226@merkur.fritz.box> <0cd1617d-b22f-4ce1-38c2-df8822c3fbbe@redhat.com> MIME-Version: 1.0 In-Reply-To: <0cd1617d-b22f-4ce1-38c2-df8822c3fbbe@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kwolf@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Krempa , John Snow , qemu-devel@nongnu.org, "open list:Block layer core" , Max Reitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Am 15.02.2021 um 17:46 hat Eric Blake geschrieben: > On 2/15/21 6:31 AM, Kevin Wolf wrote: > > Am 13.02.2021 um 00:21 hat Eric Blake geschrieben: > >> From: Peter Krempa > >> > >> Verify that the modification of the bitmap persistence over migration > >> which is controlled via BitmapMigrationBitmapAliasTransform works > >> properly. > >> > >> Based on TestCrossAliasMigration > >> > >> Signed-off-by: Peter Krempa > >> Message-Id: > >> Reviewed-by: Eric Blake > >> [eblake: Adjust test for explicit read_zeroes=False] > >> Signed-off-by: Eric Blake > > > > This breaks 297: > > > > --- /home/kwolf/source/qemu/tests/qemu-iotests/297.out > > +++ 297.out.bad > > @@ -1,2 +1,8 @@ > > === pylint === > > +************* Module 300 > > +300:605:0: C0301: Line too long (80/79) (line-too-long) > > +300:677:0: C0301: Line too long (98/79) (line-too-long) > > These two are easy fixes (add line breaks for shorter lines), but this: > > > === mypy === > > +300:646: error: Dict entry 2 has incompatible type "str": "Dict[str, bool]"; expected "str": "str" > > +Found 1 error in 1 file (checked 1 source file) > > is beyond my skill. The typing at line 33: > > BlockBitmapMapping = List[Dict[str, Union[str, List[Dict[str, str]]]]] > > is insufficient to allow our new 'transform' member in the new > transform_mapping() -> Block BitmapMapping near line 677: > > 'bitmaps': [ > { > 'name': 'bmap-a', > 'alias': 'bmap-a', > 'transform': > { > 'persistent': True > } > }, > > but I'm not sure how to tell python the right type it should be. John? To be honest, this looks sufficiently like JSON that I would just go for List[Dict[str, Any]] (as long as recursive types don't work), but if you really want to have an explicit type, I think you'd have to replace the rightmost str with Union[str, Dict[str, bool]] to allow both. Kevin