From: Cornelia Huck <cohuck@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Halil Pasic <pasic@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Thomas Huth <thuth@redhat.com>,
qemu-s390x@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH] virtio-ccw: commands on revision-less devices
Date: Tue, 16 Feb 2021 12:51:50 +0100 [thread overview]
Message-ID: <20210216125150.5cce488d.cohuck@redhat.com> (raw)
In-Reply-To: <20210216064013-mutt-send-email-mst@kernel.org>
On Tue, 16 Feb 2021 06:40:41 -0500
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> On Tue, Feb 16, 2021 at 12:18:30PM +0100, Cornelia Huck wrote:
> > The virtio standard specifies that any non-transitional device must
> > reject commands prior to revision setting (which we do) and else
> > assume revision 0 (legacy) if the driver sends a non-revision-setting
> > command first. We neglected to do the latter.
> >
> > Fortunately, nearly everything worked as intended anyway; the only
> > problem was not properly rejecting revision setting after some other
> > command had been issued. Easy to fix by setting revision to 0 if
> > we see a non-revision command on a legacy-capable revision-less
> > device.
> >
> > Signed-off-by: Cornelia Huck <cohuck@redhat.com>
>
> Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
>
> Feel free to merge.
>
> Curious how was this discovered.
Code reading :)
I have not seen any errors in the wild.
next prev parent reply other threads:[~2021-02-16 11:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 11:18 [PATCH] virtio-ccw: commands on revision-less devices Cornelia Huck
2021-02-16 11:33 ` Thomas Huth
2021-02-16 11:40 ` Michael S. Tsirkin
2021-02-16 11:51 ` Cornelia Huck [this message]
2021-02-16 11:58 ` Michael S. Tsirkin
2021-02-16 14:19 ` Halil Pasic
2021-02-16 15:54 ` Cornelia Huck
2021-02-17 14:39 ` Halil Pasic
2021-02-18 13:51 ` Cornelia Huck
2021-02-18 18:51 ` Halil Pasic
2021-02-19 11:21 ` Cornelia Huck
2021-02-19 17:01 ` Cornelia Huck
2021-02-21 11:48 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210216125150.5cce488d.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=mst@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).