From: Kevin Wolf <kwolf@redhat.com>
To: Alberto Garcia <berto@igalia.com>
Cc: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
pkrempa@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org,
Max Reitz <mreitz@redhat.com>
Subject: Re: [RFC PATCH v2 0/4] Allow changing bs->file on reopen
Date: Tue, 16 Feb 2021 17:48:07 +0100 [thread overview]
Message-ID: <20210216164807.GC5282@merkur.fritz.box> (raw)
In-Reply-To: <w514kic2cmf.fsf@maestria.local.igalia.com>
Am 16.02.2021 um 17:36 hat Alberto Garcia geschrieben:
> On Wed 10 Feb 2021 06:26:57 PM CET, Kevin Wolf wrote:
>
> > You have a test case for adding a throttling filter. Can we also
> > remove it again or is there still a problem with that? I seem to
> > remember that that was a bit trickier, though I'm not sure what it
> > was. Was it that we can't have the throttle node without a file, so it
> > would possibly still have permission conflicts?
>
> There is no problem with removing the filter anymore. See here for a
> description of the original problem:
>
> https://lists.gnu.org/archive/html/qemu-block/2020-12/msg00090.html
Ah, nice. Can we just add removing the filter again to the test then?
> But this series is based on Vladimir's branch ("update graph permissions
> update") which reworks how the permissions are calculated on reopen and
> solves the issue.
Yes, I'm aware of this. I still hope we can get a stable blockdev-reopen
for 6.0.
Kevin
next prev parent reply other threads:[~2021-02-16 17:19 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 18:44 [RFC PATCH v2 0/4] Allow changing bs->file on reopen Alberto Garcia
2021-02-08 18:44 ` [RFC PATCH v2 1/4] block: " Alberto Garcia
2021-02-09 7:37 ` Vladimir Sementsov-Ogievskiy
2021-02-10 16:52 ` Kevin Wolf
2021-02-16 12:06 ` Alberto Garcia
2021-02-08 18:44 ` [RFC PATCH v2 2/4] iotests: Update 245 to support replacing files with x-blockdev-reopen Alberto Garcia
2021-02-10 17:17 ` Kevin Wolf
2021-02-08 18:44 ` [RFC PATCH v2 3/4] block: Support multiple reopening " Alberto Garcia
2021-02-09 8:03 ` Vladimir Sementsov-Ogievskiy
2021-02-16 16:33 ` Alberto Garcia
2021-02-24 12:33 ` Kevin Wolf
2021-02-25 17:02 ` Vladimir Sementsov-Ogievskiy
2021-03-01 11:07 ` Kevin Wolf
2021-03-01 11:57 ` Vladimir Sementsov-Ogievskiy
2021-03-01 12:21 ` Peter Krempa
2021-02-26 11:51 ` Alberto Garcia
2021-02-08 18:44 ` [RFC PATCH v2 4/4] iotests: Test reopening multiple devices at the same time Alberto Garcia
2021-02-09 7:15 ` [RFC PATCH v2 0/4] Allow changing bs->file on reopen Vladimir Sementsov-Ogievskiy
2021-02-10 17:26 ` Kevin Wolf
2021-02-12 14:41 ` Peter Krempa
2021-02-16 16:36 ` Alberto Garcia
2021-02-16 16:48 ` Kevin Wolf [this message]
2021-02-16 17:25 ` Alberto Garcia
2021-02-16 17:51 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210216164807.GC5282@merkur.fritz.box \
--to=kwolf@redhat.com \
--cc=berto@igalia.com \
--cc=mreitz@redhat.com \
--cc=pkrempa@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).