From: Alessandro Di Federico via <qemu-devel@nongnu.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: "Taylor Simpson" <tsimpson@quicinc.com>,
qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
bcain@quicinc.com, "Fam Zheng" <fam@euphon.net>,
richard.henderson@linaro.org, laurent@vivier.eu
Subject: Re: [PATCH v8 35/35] Add Dockerfile for hexagon
Date: Wed, 17 Feb 2021 18:23:34 +0100 [thread overview]
Message-ID: <20210217182334.0fb3b75e@orange> (raw)
In-Reply-To: <6a5411a3-3d48-d30e-df70-4c73328c5fed@amsat.org>
On Sun, 14 Feb 2021 19:50:41 +0100
Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> Hi Alessandro!
Hi Philippe!
> I had to add this to build your image with QEMU build system:
>
> -- >8 --
>
> diff --git a/tests/docker/Makefile.include
> b/tests/docker/Makefile.include index 93b29ad823e..ba73fb4b1f0 100644
> --- a/tests/docker/Makefile.include
> +++ b/tests/docker/Makefile.include
> @@ -146,6 +146,8 @@ docker-image-debian-riscv64-cross:
> docker-image-debian10 docker-image-debian-s390x-cross:
> docker-image-debian10 docker-image-debian-sh4-cross:
> docker-image-debian10 docker-image-debian-sparc64-cross:
> docker-image-debian10
>+docker-image-debian-hexagon-cross-build-local:
> \
>+
> EXTRA_FILES:=$(SRC_PATH)/tests/docker/dockerfiles/debian-hexagon-cross.build-toolchain.sh
>
> docker-image-travis: NOUSER=1
>
> ---
OK, I'll drop `-local` (see below).
> > +++ b/tests/docker/dockerfiles/debian-hexagon-cross.docker
> > @@ -0,0 +1 @@
> > +FROM revng/qemu:debian-hexagon-cross
>
> Once this patch gets merged, the image will be available on
> qemu/qemu:debian-hexagon-cross.
>
> I suppose for the final merge patch we want:
> - rm debian-hexagon-cross.docker
> - mv debian-hexagon-cross-build-local.docker
> debian-hexagon-cross.docker
>
> Is that correct?
The `revng/qemu:debian-hexagon-cross` image was there only to let
people quickly try out a toolchain without building it from source.
If building from source is OK with you, that works for us.
In any case, people will be able to use
`qemu/qemu:debian-hexagon-cross`, right?
> If so, can you amend that detail after the '---'
> separator of the commit description so we don't merge this patch
> as it?
I'm a bit confused, do you want me to send a patch corrected by hand
here?
I'll send a new patch tomorrow.
> Also, can you add a job to build your image in
> .gitlab-ci.d/containers.yml?
OK, is there a quick way for me to test changes I make to that file?
--
Alessandro Di Federico
rev.ng Srls, CEO
next prev parent reply other threads:[~2021-02-17 17:24 UTC|newest]
Thread overview: 101+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 5:45 [PATCH v8 00/35] Hexagon patch series Taylor Simpson
2021-02-08 5:45 ` [PATCH v8 01/35] Hexagon Update MAINTAINERS file Taylor Simpson
2021-02-08 5:45 ` [PATCH v8 02/35] Hexagon (target/hexagon) README Taylor Simpson
2021-02-08 5:45 ` [PATCH v8 03/35] Hexagon (include/elf.h) ELF machine definition Taylor Simpson
2021-02-08 5:45 ` [PATCH v8 04/35] Hexagon (target/hexagon) scalar core definition Taylor Simpson
2021-02-08 5:45 ` [PATCH v8 05/35] Hexagon (disas) disassembler Taylor Simpson
2021-02-08 5:45 ` [PATCH v8 06/35] Hexagon (target/hexagon) register names Taylor Simpson
2021-02-08 5:45 ` [PATCH v8 07/35] Hexagon (target/hexagon) scalar core helpers Taylor Simpson
2021-02-08 5:45 ` [PATCH v8 08/35] Hexagon (target/hexagon) GDB Stub Taylor Simpson
2021-02-08 5:45 ` [PATCH v8 09/35] Hexagon (target/hexagon) architecture types Taylor Simpson
2021-02-12 0:32 ` Philippe Mathieu-Daudé
2021-02-14 17:16 ` Richard Henderson
2021-02-08 5:46 ` [PATCH v8 10/35] Hexagon (target/hexagon) instruction and packet types Taylor Simpson
2021-02-14 17:21 ` Richard Henderson
2021-02-08 5:46 ` [PATCH v8 11/35] Hexagon (target/hexagon) register fields Taylor Simpson
2021-02-14 17:25 ` Richard Henderson
2021-02-08 5:46 ` [PATCH v8 12/35] Hexagon (target/hexagon) instruction attributes Taylor Simpson
2021-02-14 18:00 ` Richard Henderson
2021-02-08 5:46 ` [PATCH v8 13/35] Hexagon (target/hexagon) instruction/packet decode Taylor Simpson
2021-02-14 18:31 ` Richard Henderson
2021-03-14 17:23 ` Taylor Simpson
2021-02-08 5:46 ` [PATCH v8 14/35] Hexagon (target/hexagon) instruction printing Taylor Simpson
2021-02-14 18:36 ` Richard Henderson
2021-02-08 5:46 ` [PATCH v8 15/35] Hexagon (target/hexagon/arch.[ch]) utility functions Taylor Simpson
2021-02-14 20:13 ` Richard Henderson
2021-03-18 3:57 ` Taylor Simpson
2021-02-08 5:46 ` [PATCH v8 16/35] Hexagon (target/hexagon/conv_emu.[ch]) " Taylor Simpson
2021-02-14 20:57 ` Richard Henderson
2021-03-18 3:57 ` Taylor Simpson
2021-03-18 13:30 ` Richard Henderson
2021-03-18 14:11 ` Taylor Simpson
2021-03-18 15:35 ` Richard Henderson
2021-03-18 18:03 ` Taylor Simpson
2021-03-18 18:32 ` Richard Henderson
2021-02-08 5:46 ` [PATCH v8 17/35] Hexagon (target/hexagon/fma_emu.[ch]) " Taylor Simpson
2021-02-12 0:31 ` Philippe Mathieu-Daudé
2021-02-14 23:14 ` Richard Henderson
2021-03-18 3:57 ` Taylor Simpson
2021-02-08 5:46 ` [PATCH v8 18/35] Hexagon (target/hexagon/imported) arch import Taylor Simpson
2021-02-08 5:46 ` [PATCH v8 19/35] Hexagon (target/hexagon) generator phase 1 - C preprocessor for semantics Taylor Simpson
2021-02-14 23:18 ` Richard Henderson
2021-02-08 5:46 ` [PATCH v8 20/35] Hexagon (target/hexagon) generator phase 2 - generate header files Taylor Simpson
2021-02-14 23:20 ` Richard Henderson
2021-02-08 5:46 ` [PATCH v8 21/35] Hexagon (target/hexagon) generator phase 3 - C preprocessor for decode tree Taylor Simpson
2021-02-14 23:24 ` Richard Henderson
2021-02-08 5:46 ` [PATCH v8 22/35] Hexagon (target/hexagon) generater phase 4 - " Taylor Simpson
2021-02-14 23:26 ` Richard Henderson
2021-02-08 5:46 ` [PATCH v8 23/35] Hexagon (target/hexagon) opcode data structures Taylor Simpson
2021-02-12 0:26 ` Philippe Mathieu-Daudé
2021-02-14 23:27 ` Richard Henderson
2021-02-08 5:46 ` [PATCH v8 24/35] Hexagon (target/hexagon) macros Taylor Simpson
2021-02-14 23:36 ` Richard Henderson
2021-02-08 5:46 ` [PATCH v8 25/35] Hexagon (target/hexagon) instruction classes Taylor Simpson
2021-02-14 23:41 ` Richard Henderson
2021-03-14 0:39 ` Taylor Simpson
2021-02-08 5:46 ` [PATCH v8 26/35] Hexagon (target/hexagon) TCG generation Taylor Simpson
2021-02-12 0:22 ` Philippe Mathieu-Daudé
2021-04-05 23:03 ` Taylor Simpson
2021-04-06 9:20 ` Alex Bennée
2021-04-06 15:44 ` Taylor Simpson
2021-02-15 0:06 ` Richard Henderson
2021-03-14 0:39 ` Taylor Simpson
2021-03-14 1:39 ` Richard Henderson
2021-03-15 3:09 ` Taylor Simpson
2021-02-08 5:46 ` [PATCH v8 27/35] Hexagon (target/hexagon) TCG for instructions with multiple definitions Taylor Simpson
2021-02-15 0:33 ` Richard Henderson
2021-03-14 0:41 ` Taylor Simpson
2021-03-14 18:02 ` Richard Henderson
2021-03-15 2:59 ` Taylor Simpson
2021-02-08 5:46 ` [PATCH v8 28/35] Hexagon (target/hexagon) TCG for floating point instructions Taylor Simpson
2021-02-15 0:34 ` Richard Henderson
2021-02-08 5:46 ` [PATCH v8 29/35] Hexagon (target/hexagon) translation Taylor Simpson
2021-02-15 1:03 ` Richard Henderson
2021-03-14 0:40 ` Taylor Simpson
2021-03-14 1:44 ` Richard Henderson
2021-03-15 3:06 ` Taylor Simpson
2021-03-15 13:31 ` Richard Henderson
2021-03-15 22:19 ` Taylor Simpson
2021-02-08 5:46 ` [PATCH v8 30/35] Hexagon (linux-user/hexagon) Linux user emulation Taylor Simpson
2021-02-08 5:46 ` [PATCH v8 31/35] Hexagon (tests/tcg/hexagon) TCG tests - multiarch Taylor Simpson
2021-02-14 18:14 ` Philippe Mathieu-Daudé
2021-02-15 1:05 ` Richard Henderson
2021-02-08 5:46 ` [PATCH v8 32/35] Hexagon (tests/tcg/hexagon) TCG tests - atomics/load/store/misc Taylor Simpson
2021-02-15 1:09 ` Richard Henderson
2021-02-08 5:46 ` [PATCH v8 33/35] Hexagon (tests/tcg/hexagon) TCG tests - floating point Taylor Simpson
2021-02-15 1:10 ` Richard Henderson
2021-02-08 5:46 ` [PATCH v8 34/35] Hexagon build infrastructure Taylor Simpson
2021-02-15 1:11 ` Richard Henderson
2021-02-08 5:46 ` [PATCH v8 35/35] Add Dockerfile for hexagon Taylor Simpson
2021-02-14 18:50 ` Philippe Mathieu-Daudé
2021-02-17 17:23 ` Alessandro Di Federico via [this message]
2021-02-17 17:33 ` Philippe Mathieu-Daudé
2021-02-27 14:10 ` Philippe Mathieu-Daudé
2021-02-27 14:32 ` Brian Cain
2021-02-08 6:25 ` [PATCH v8 00/35] Hexagon patch series no-reply
2021-02-15 1:23 ` Richard Henderson
2021-02-16 20:59 ` Taylor Simpson
2021-02-16 21:17 ` Peter Maydell
2021-02-17 14:23 ` Philippe Mathieu-Daudé
2021-02-17 17:05 ` Richard Henderson
2021-02-17 16:58 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210217182334.0fb3b75e@orange \
--to=qemu-devel@nongnu.org \
--cc=ale.qemu@rev.ng \
--cc=alex.bennee@linaro.org \
--cc=bcain@quicinc.com \
--cc=f4bug@amsat.org \
--cc=fam@euphon.net \
--cc=laurent@vivier.eu \
--cc=richard.henderson@linaro.org \
--cc=tsimpson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).