From: Kevin Wolf <kwolf@redhat.com>
To: Alberto Garcia <berto@igalia.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
Max Reitz <mreitz@redhat.com>
Subject: Re: [PATCH] iotests: Drop deprecated 'props' from object-add
Date: Fri, 19 Feb 2021 14:26:55 +0100 [thread overview]
Message-ID: <20210219132655.GD5750@merkur.fritz.box> (raw)
In-Reply-To: <w51pn0wql96.fsf@maestria.local.igalia.com>
Am 19.02.2021 um 13:45 hat Alberto Garcia geschrieben:
> On Fri 19 Feb 2021 01:21:49 PM CET, Kevin Wolf <kwolf@redhat.com> wrote:
> >> log(vm.qmp('object-add', qom_type='throttle-group', id='tg0',
> >> - props={ 'x-bps-total': size }))
> >> + x_bps_total=size))
> >
> > x-bps-total isn't a stable interface, I'd prefer to use limits.
> >
> > My patch from November [1] had this:
>
> Do you want me to resend mine, or wait for yours, or what then? :)
It's your patch, you decide. :-)
I haven't compared the patches in detail yet, so if you think merging my
patch has the same result and is less work, I can do that. If not and
you send a v2, I'll take that. Or you see differences and post review
comments to my patch instead of a v2 of yours. I'm fine with any of
these options.
Kevin
prev parent reply other threads:[~2021-02-19 13:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 17:16 [PATCH] iotests: Drop deprecated 'props' from object-add Alberto Garcia
2021-02-19 12:04 ` Max Reitz
2021-02-19 12:35 ` Alberto Garcia
2021-02-19 12:21 ` Kevin Wolf
2021-02-19 12:45 ` Alberto Garcia
2021-02-19 13:26 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210219132655.GD5750@merkur.fritz.box \
--to=kwolf@redhat.com \
--cc=berto@igalia.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).