qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, John Snow <jsnow@redhat.com>
Subject: [PULL 13/18] qapi/introspect.py: remove _gen_variants helper
Date: Fri, 19 Feb 2021 15:49:34 +0100	[thread overview]
Message-ID: <20210219144939.604488-14-armbru@redhat.com> (raw)
In-Reply-To: <20210219144939.604488-1-armbru@redhat.com>

From: John Snow <jsnow@redhat.com>

It is easier to give a name to all of the dictly-typed objects we pass
around in introspect.py by removing this helper, as it does not return
an object that has any knowable type by itself.

Inline it into its only caller instead.

Signed-off-by: John Snow <jsnow@redhat.com>
Message-Id: <20210216021809.134886-14-jsnow@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 scripts/qapi/introspect.py | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/scripts/qapi/introspect.py b/scripts/qapi/introspect.py
index 26e6f73e5d..da7bc8883c 100644
--- a/scripts/qapi/introspect.py
+++ b/scripts/qapi/introspect.py
@@ -242,10 +242,6 @@ const QLitObject %(c_name)s = %(c_string)s;
             obj['features'] = self._gen_features(member.features)
         return Annotated(obj, member.ifcond)
 
-    def _gen_variants(self, tag_name, variants):
-        return {'tag': tag_name,
-                'variants': [self._gen_variant(v) for v in variants]}
-
     def _gen_variant(self, variant):
         obj = {'case': variant.name, 'type': self._use_type(variant.type)}
         return Annotated(obj, variant.ifcond)
@@ -269,9 +265,8 @@ const QLitObject %(c_name)s = %(c_string)s;
                                members, variants):
         obj = {'members': [self._gen_member(m) for m in members]}
         if variants:
-            obj.update(self._gen_variants(variants.tag_member.name,
-                                          variants.variants))
-
+            obj['tag'] = variants.tag_member.name
+            obj['variants'] = [self._gen_variant(v) for v in variants.variants]
         self._gen_tree(name, 'object', obj, ifcond, features)
 
     def visit_alternate_type(self, name, info, ifcond, features, variants):
-- 
2.26.2



  parent reply	other threads:[~2021-02-19 15:33 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-19 14:49 [PULL 00/18] QAPI patches patches for 2021-02-18 Markus Armbruster
2021-02-19 14:49 ` [PULL 01/18] qapi: Replace List[str] with Sequence[str] for ifcond Markus Armbruster
2021-02-19 14:49 ` [PULL 02/18] qapi/introspect.py: assert schema is not None Markus Armbruster
2021-02-19 14:49 ` [PULL 03/18] qapi/introspect.py: use _make_tree for features nodes Markus Armbruster
2021-02-19 14:49 ` [PULL 04/18] qapi/introspect.py: add _gen_features helper Markus Armbruster
2021-02-19 14:49 ` [PULL 05/18] qapi/introspect.py: guard against ifcond/comment misuse Markus Armbruster
2021-02-19 14:49 ` [PULL 06/18] qapi/introspect.py: Unify return type of _make_tree() Markus Armbruster
2021-02-19 14:49 ` [PULL 07/18] qapi/introspect.py: replace 'extra' dict with 'comment' argument Markus Armbruster
2021-02-19 14:49 ` [PULL 08/18] qapi/introspect.py: Always define all 'extra' dict keys Markus Armbruster
2021-02-19 14:49 ` [PULL 09/18] qapi/introspect.py: Introduce preliminary tree typing Markus Armbruster
2021-02-19 14:49 ` [PULL 10/18] qapi/introspect.py: create a typed 'Annotated' data strutcure Markus Armbruster
2021-02-19 14:49 ` [PULL 11/18] qapi/introspect.py: improve _tree_to_qlit error message Markus Armbruster
2021-02-19 14:49 ` [PULL 12/18] qapi/introspect.py: improve readability of _tree_to_qlit Markus Armbruster
2021-02-19 14:49 ` Markus Armbruster [this message]
2021-02-19 14:49 ` [PULL 14/18] qapi/introspect.py: add type hint annotations Markus Armbruster
2021-02-19 14:49 ` [PULL 15/18] qapi/introspect.py: Add docstrings to _gen_tree and _tree_to_qlit Markus Armbruster
2021-02-19 14:49 ` [PULL 16/18] qapi/introspect.py: Update copyright and authors list Markus Armbruster
2021-02-19 14:49 ` [PULL 17/18] qapi/introspect.py: Type _gen_tree variants as Sequence[str] Markus Armbruster
2021-02-19 14:49 ` [PULL 18/18] qapi/introspect.py: set _gen_tree's default ifcond argument to () Markus Armbruster
2021-02-19 22:20 ` [PULL 00/18] QAPI patches patches for 2021-02-18 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210219144939.604488-14-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).