qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [PULL 1/8] spice: flush on GL update before notifying client
Date: Fri, 19 Feb 2021 23:00:29 +0100	[thread overview]
Message-ID: <20210219220036.100654-2-kraxel@redhat.com> (raw)
In-Reply-To: <20210219220036.100654-1-kraxel@redhat.com>

From: Marc-André Lureau <marcandre.lureau@redhat.com>

Since the introduction of spice/virgl support in commit
474114b7 ("spice: add opengl/virgl/dmabuf support"), the drawing isn't
being flushed before notifying the client. This results in
outdated/sluggish drawing on client side, in particular when using the
Linux console.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20210216092056.2301293-1-marcandre.lureau@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 ui/spice-display.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/ui/spice-display.c b/ui/spice-display.c
index 6f32b66a6e75..d562c6408405 100644
--- a/ui/spice-display.c
+++ b/ui/spice-display.c
@@ -1087,6 +1087,7 @@ static void qemu_spice_gl_update(DisplayChangeListener *dcl,
 
     trace_qemu_spice_gl_update(ssd->qxl.id, w, h, x, y);
     qemu_spice_gl_block(ssd, true);
+    glFlush();
     cookie = (uintptr_t)qxl_cookie_new(QXL_COOKIE_TYPE_GL_DRAW_DONE, 0);
     spice_qxl_gl_draw_async(&ssd->qxl, x, y, w, h, cookie);
 }
-- 
2.29.2



  reply	other threads:[~2021-02-19 22:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-19 22:00 [PULL 0/8] Ui 20210219 patches Gerd Hoffmann
2021-02-19 22:00 ` Gerd Hoffmann [this message]
2021-02-19 22:00 ` [PULL 2/8] spice: flush drawing before notifying client Gerd Hoffmann
2021-02-19 22:00 ` [PULL 3/8] ui/cocoa: Support unique keys of JIS keyboards Gerd Hoffmann
2021-02-19 22:00 ` [PULL 4/8] ui/cocoa: Do not copy members of pixman image Gerd Hoffmann
2021-02-19 22:00 ` [PULL 5/8] spice-app: avoid crash when core spice module doesn't loaded Gerd Hoffmann
2021-02-19 22:00 ` [PULL 6/8] ui/cocoa: Interpret left button down as is when command is pressed Gerd Hoffmann
2021-02-19 22:00 ` [PULL 7/8] ui/cocoa: Statically allocate dcl Gerd Hoffmann
2021-02-19 22:00 ` [PULL 8/8] ui/console: Remove dpy_gl_ctx_get_current Gerd Hoffmann
2021-02-20 19:27 ` [PULL 0/8] Ui 20210219 patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210219220036.100654-2-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).