qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Michael Tokarev" <mjt@tls.msk.ru>,
	"Laurent Vivier" <laurent@vivier.eu>,
	"Paul Durrant" <paul@xen.org>
Subject: [PULL 01/12] hw/i386/xen: Remove dead code
Date: Sat, 20 Feb 2021 13:35:14 +0100	[thread overview]
Message-ID: <20210220123525.1353731-2-laurent@vivier.eu> (raw)
In-Reply-To: <20210220123525.1353731-1-laurent@vivier.eu>

From: Philippe Mathieu-Daudé <philmd@redhat.com>

'drivers_blacklisted' is never accessed, remove it.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Paul Durrant <paul@xen.org>
Message-Id: <20210202155644.998812-1-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
 hw/i386/xen/xen_platform.c | 13 ++-----------
 1 file changed, 2 insertions(+), 11 deletions(-)

diff --git a/hw/i386/xen/xen_platform.c b/hw/i386/xen/xen_platform.c
index 7c4db35debbd..01ae1fb16184 100644
--- a/hw/i386/xen/xen_platform.c
+++ b/hw/i386/xen/xen_platform.c
@@ -60,7 +60,6 @@ struct PCIXenPlatformState {
     MemoryRegion bar;
     MemoryRegion mmio_bar;
     uint8_t flags; /* used only for version_id == 2 */
-    int drivers_blacklisted;
     uint16_t driver_product_version;
 
     /* Log from guest drivers */
@@ -245,18 +244,10 @@ static void platform_fixed_ioport_writeb(void *opaque, uint32_t addr, uint32_t v
 
 static uint32_t platform_fixed_ioport_readw(void *opaque, uint32_t addr)
 {
-    PCIXenPlatformState *s = opaque;
-
     switch (addr) {
     case 0:
-        if (s->drivers_blacklisted) {
-            /* The drivers will recognise this magic number and refuse
-             * to do anything. */
-            return 0xd249;
-        } else {
-            /* Magic value so that you can identify the interface. */
-            return 0x49d2;
-        }
+        /* Magic value so that you can identify the interface. */
+        return 0x49d2;
     default:
         return 0xffff;
     }
-- 
2.29.2



  reply	other threads:[~2021-02-20 12:39 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-20 12:35 [PULL 00/12] Trivial branch for 6.0 patches Laurent Vivier
2021-02-20 12:35 ` Laurent Vivier [this message]
2021-02-20 12:35 ` [PULL 02/12] hw/block/fdc: Remove the check_media_rate property Laurent Vivier
2021-02-20 12:35 ` [PULL 03/12] Fix SPDX-License-Identifier typos Laurent Vivier
2021-02-20 12:35 ` [PULL 04/12] MAINTAINERS: add my github tree URL Laurent Vivier
2021-02-20 12:35 ` [PULL 05/12] virtio-pmem: put it into the 'storage' category Laurent Vivier
2021-02-20 12:35 ` [PULL 06/12] vmmouse: put it into the 'input' category Laurent Vivier
2021-02-20 12:35 ` [PULL 07/12] nvdimm: put it into the 'storage' category Laurent Vivier
2021-02-20 12:35 ` [PULL 08/12] tpm: put some tpm devices into the correct category Laurent Vivier
2021-02-20 12:35 ` [PULL 09/12] u2f-passthru: put it into the 'misc' category Laurent Vivier
2021-02-20 12:35 ` [PULL 10/12] hw/scsi/megasas: Remove pointless parenthesis Laurent Vivier
2021-02-20 12:35 ` [PULL 11/12] target/avr/cpu: Use device_class_set_parent_realize() Laurent Vivier
2021-02-20 12:35 ` [PULL 12/12] MAINTAINERS: Fix default-configs/ entries Laurent Vivier
2021-02-21 15:20 ` [PULL 00/12] Trivial branch for 6.0 patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210220123525.1353731-2-laurent@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=mjt@tls.msk.ru \
    --cc=paul@xen.org \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).