From: Marian Postevca <posteuca@mutex.one>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Xiao Guangrong <xiaoguangrong.eric@gmail.com>,
Sergio Lopez <slp@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Dongjiu Geng <gengdongjiu@huawei.com>,
Shannon Zhao <shannon.zhaosl@gmail.com>,
Xiang Zheng <zhengxiang9@huawei.com>,
"open list : ACPI/HEST/GHES" <qemu-arm@nongnu.org>,
Marian Postevca <posteuca@mutex.one>,
Igor Mammedov <imammedo@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>
Subject: [PATCH v2 0/2] Rework ACPI OEM fields handling to simplify code (was: acpi: Remove duplicated code handling OEM ID and OEM table ID fields)
Date: Sun, 21 Feb 2021 02:17:35 +0200 [thread overview]
Message-ID: <20210221001737.24499-1-posteuca@mutex.one> (raw)
This patch series consolidates ACPI OEM fields handling
by:
- Moving common code in PC and MICROVM to X86.
- Changes unnecessary dynamic memory allocation to static allocation
- Uses dedicated structure to keep values of fields instead of two
separate strings
- Adds helper macros to initialize the structure
v2:
- Move the setters/getters of OEM fields to X86MachineState to
remove duplication
- Change commit message to make it clear the second commit is
a re-factor
Marian Postevca (2):
acpi: Move setters/getters of oem fields to X86MachineState
acpi: Consolidate the handling of OEM ID and OEM Table ID fields
hw/acpi/hmat.h | 2 +-
hw/i386/acpi-common.h | 2 +-
include/hw/acpi/acpi-build-oem.h | 55 ++++++++++++++++++++++
include/hw/acpi/aml-build.h | 16 +++----
include/hw/acpi/ghes.h | 2 +-
include/hw/acpi/pci.h | 2 +-
include/hw/acpi/vmgenid.h | 2 +-
include/hw/arm/virt.h | 4 +-
include/hw/i386/microvm.h | 4 --
include/hw/i386/pc.h | 4 --
include/hw/i386/x86.h | 4 ++
include/hw/mem/nvdimm.h | 4 +-
hw/acpi/aml-build.c | 27 ++++++-----
hw/acpi/ghes.c | 5 +-
hw/acpi/hmat.c | 4 +-
hw/acpi/nvdimm.c | 22 +++++----
hw/acpi/pci.c | 4 +-
hw/acpi/vmgenid.c | 6 ++-
hw/arm/virt-acpi-build.c | 40 ++++++----------
hw/arm/virt.c | 16 +++----
hw/i386/acpi-build.c | 78 +++++++++++++++-----------------
hw/i386/acpi-common.c | 4 +-
hw/i386/acpi-microvm.c | 13 ++----
hw/i386/microvm.c | 66 ---------------------------
hw/i386/pc.c | 63 --------------------------
hw/i386/x86.c | 61 +++++++++++++++++++++++++
26 files changed, 237 insertions(+), 273 deletions(-)
create mode 100644 include/hw/acpi/acpi-build-oem.h
--
2.26.2
next reply other threads:[~2021-02-21 0:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-21 0:17 Marian Postevca [this message]
2021-02-21 0:17 ` [PATCH 1/2] acpi: Move setters/getters of oem fields to X86MachineState Marian Postevca
2021-03-01 20:24 ` Igor Mammedov
2021-02-21 0:17 ` [PATCH 2/2] acpi: Consolidate the handling of OEM ID and OEM Table ID fields Marian Postevca
2021-03-01 20:29 ` Igor Mammedov
2021-03-22 14:12 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210221001737.24499-1-posteuca@mutex.one \
--to=posteuca@mutex.one \
--cc=ehabkost@redhat.com \
--cc=gengdongjiu@huawei.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=shannon.zhaosl@gmail.com \
--cc=slp@redhat.com \
--cc=xiaoguangrong.eric@gmail.com \
--cc=zhengxiang9@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).