From: Cleber Rosa <crosa@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Fam Zheng" <fam@euphon.net>, "Thomas Huth" <thuth@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Erik Skultety" <eskultet@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Cleber Rosa" <crosa@redhat.com>,
"Andrea Bolognani" <abologna@redhat.com>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Willian Rampazzo" <wrampazz@redhat.com>,
"Stefan Hajnoczi" <stefanha@gmail.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Beraldo Leal" <bleal@redhat.com>
Subject: [PATCH 1/3] scripts/ci/gitlab-pipeline-status: split utlity function for HTTP GET
Date: Mon, 22 Feb 2021 14:32:38 -0500 [thread overview]
Message-ID: <20210222193240.921250-2-crosa@redhat.com> (raw)
In-Reply-To: <20210222193240.921250-1-crosa@redhat.com>
This simply splits out the code that does an HTTP GET so that it
can be used for other API requests.
Signed-off-by: Cleber Rosa <crosa@redhat.com>
---
scripts/ci/gitlab-pipeline-status | 17 ++++++++++++-----
1 file changed, 12 insertions(+), 5 deletions(-)
diff --git a/scripts/ci/gitlab-pipeline-status b/scripts/ci/gitlab-pipeline-status
index 78e72f6008..0c1e8bd8a7 100755
--- a/scripts/ci/gitlab-pipeline-status
+++ b/scripts/ci/gitlab-pipeline-status
@@ -48,18 +48,25 @@ def get_local_branch_commit(branch):
return result
-def get_pipeline_status(project_id, commit_sha1):
+def get_json_http_response(url):
"""
- Returns the JSON content of the pipeline status API response
+ Returns the JSON content of an HTTP GET request to gitlab.com
"""
- url = '/api/v4/projects/{}/pipelines?sha={}'.format(project_id,
- commit_sha1)
connection = http.client.HTTPSConnection('gitlab.com')
connection.request('GET', url=url)
response = connection.getresponse()
if response.code != http.HTTPStatus.OK:
raise CommunicationFailure("Failed to receive a successful response")
- json_response = json.loads(response.read())
+ return json.loads(response.read())
+
+
+def get_pipeline_status(project_id, commit_sha1):
+ """
+ Returns the JSON content of the pipeline status API response
+ """
+ url = '/api/v4/projects/{}/pipelines?sha={}'.format(project_id,
+ commit_sha1)
+ json_response = get_json_http_response(url)
# As far as I can tell, there should be only one pipeline for the same
# project + commit. If this assumption is false, we can add further
--
2.25.4
next prev parent reply other threads:[~2021-02-22 19:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-22 19:32 [PATCH 0/3] gitlab-pipeline-status script: provide more information on errors Cleber Rosa
2021-02-22 19:32 ` Cleber Rosa [this message]
2021-02-23 14:38 ` [PATCH 1/3] scripts/ci/gitlab-pipeline-status: split utlity function for HTTP GET Wainer dos Santos Moschetta
2021-02-23 18:09 ` Alex Bennée
2021-02-22 19:32 ` [PATCH 2/3] scripts/ci/gitlab-pipeline-status: give more information on failures Cleber Rosa
2021-02-23 14:40 ` Wainer dos Santos Moschetta
2021-02-23 18:09 ` Alex Bennée
2021-02-22 19:32 ` [PATCH 3/3] scripts/ci/gitlab-pipeline-status: give more info when pipeline not found Cleber Rosa
2021-02-23 14:43 ` Wainer dos Santos Moschetta
2021-02-23 14:52 ` [PATCH 0/3] gitlab-pipeline-status script: provide more information on errors Wainer dos Santos Moschetta
2021-02-23 15:19 ` Erik Skultety
2021-02-23 15:53 ` Wainer dos Santos Moschetta
2021-03-03 17:54 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210222193240.921250-2-crosa@redhat.com \
--to=crosa@redhat.com \
--cc=abologna@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=bleal@redhat.com \
--cc=ehabkost@redhat.com \
--cc=eskultet@redhat.com \
--cc=fam@euphon.net \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
--cc=wrampazz@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).