From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77E94C433E0 for ; Tue, 23 Feb 2021 09:28:41 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C867A64DE9 for ; Tue, 23 Feb 2021 09:28:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C867A64DE9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:32842 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lETzh-00063w-V7 for qemu-devel@archiver.kernel.org; Tue, 23 Feb 2021 04:28:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48442) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lETus-0001Wc-Tk; Tue, 23 Feb 2021 04:23:40 -0500 Received: from mail-lf1-x12d.google.com ([2a00:1450:4864:20::12d]:46727) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lETup-0007zi-1d; Tue, 23 Feb 2021 04:23:38 -0500 Received: by mail-lf1-x12d.google.com with SMTP id v5so10028235lft.13; Tue, 23 Feb 2021 01:23:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=BZEEiZGLkUC4JXUmIjtT0EcG55ILGQxTF2Zgogg5uGM=; b=NEu7efB93ptQgF/zTMv5kN5vGZSyj4qTI43XfUFEhF6ZepeeyLP54XILVJfpYr1JXB 4EOJ2kpV1qBY+iQFALsGn+e21a4TFGqHacrRN2yWgqUyeMrERAet8/AlmDspE0cLGfg3 3Y/uviJdraYRHE6pGMzeda/bR6m/MenT78P4W/ESRMxbOQDJPObjYNn1cPUXeUMBJgFP nBbZj9Ru++ZKayW1PCVXjZ4dtxAqa/n7czY3wY/aYHY6q5eS24UiSOx37YDWJw8EWgFU ++sskxjkdAyc/7DQQMxASEWNPWGCAcE921JrE5znoDMJQ4qMN0yw1h5xorUTPnV2Cl0Y g2Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=BZEEiZGLkUC4JXUmIjtT0EcG55ILGQxTF2Zgogg5uGM=; b=BXkUrFtEtk2T8F7SWQhjWoyHsNns6ukxhbPT//5mqGHKx7vniZHGBRpUa2gJEscukG FOFTKrHIvgyfBNnpctwlFPid1sOb6ArEdR/kpRpZJimVkLvUuSlM+26EPSAoAY+vJGBY roqlTxRwyKt60Naedx3aSFl/iyItgzhkDeBLFQPaeMxYopuqGbr8cSkYZvvIIQs7LnPC VS1IUZSGzazsZWk6TCeU01dDQOYhiqO8UCRd6ezV6R1P/Wy9SjoXJ0THtoL8Nxe1b8k1 932FpoKHHe3LTwentRHSEVhDvqOvxxhmG1sjzwlGOfqzZURWKWecK40QCWhGQiSr6Q2H Gg+w== X-Gm-Message-State: AOAM533uEVcvp1jsPWV2wS2lcrgG1eKXRcxtW53QJcwKCopK362Mdchl 7oT6IcBBItqFmX63yHz9cuo= X-Google-Smtp-Source: ABdhPJypaCaBm5kTb6DazPwUOVv78FYMiQ7dvyDUgyLAy7SkyK7f8Qfgaf327qiSZTXV+JTOVQHmfg== X-Received: by 2002:a19:7f48:: with SMTP id a69mr16137993lfd.444.1614072211302; Tue, 23 Feb 2021 01:23:31 -0800 (PST) Received: from gmail.com (81-231-232-130-no39.tbcn.telia.com. [81.231.232.130]) by smtp.gmail.com with ESMTPSA id x27sm2473947lfu.151.2021.02.23.01.23.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Feb 2021 01:23:30 -0800 (PST) Date: Tue, 23 Feb 2021 10:23:30 +0100 From: "Edgar E. Iglesias" To: Bin Meng Subject: Re: [PATCH v4 3/5] hw/arm: xlnx-zynqmp: Connect a Xilinx CSU DMA module for QSPI Message-ID: <20210223092330.GV477672@toto> References: <20210222130514.2167-1-bmeng.cn@gmail.com> <20210222130514.2167-4-bmeng.cn@gmail.com> <20210223090144.GS477672@toto> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=2a00:1450:4864:20::12d; envelope-from=edgar.iglesias@gmail.com; helo=mail-lf1-x12d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Xuzhou Cheng , Bin Meng , "qemu-devel@nongnu.org Developers" , Francisco Iglesias , qemu-arm , Alistair Francis Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Feb 23, 2021 at 05:20:36PM +0800, Bin Meng wrote: > Hi Edgar, > > On Tue, Feb 23, 2021 at 5:01 PM Edgar E. Iglesias > wrote: > > > > On Mon, Feb 22, 2021 at 09:05:12PM +0800, Bin Meng wrote: > > > From: Xuzhou Cheng > > > > > > Add a Xilinx CSU DMA module to ZynqMP SoC, and connent the stream > > > link of GQSPI to CSU DMA. > > > > > > Signed-off-by: Xuzhou Cheng > > > Signed-off-by: Bin Meng > > > > > > --- > > > > > > Changes in v4: > > > - Rename "csu_dma" to "qspi_dma" > > > > > > Changes in v3: > > > - new patch: xlnx-zynqmp: Add XLNX CSU DMA module > > > > > > include/hw/arm/xlnx-zynqmp.h | 2 ++ > > > hw/arm/xlnx-zynqmp.c | 14 ++++++++++++++ > > > hw/arm/Kconfig | 1 + > > > 3 files changed, 17 insertions(+) > > > > > > diff --git a/include/hw/arm/xlnx-zynqmp.h b/include/hw/arm/xlnx-zynqmp.h > > > index be15cc8814..2edeed911c 100644 > > > --- a/include/hw/arm/xlnx-zynqmp.h > > > +++ b/include/hw/arm/xlnx-zynqmp.h > > > @@ -35,6 +35,7 @@ > > > #include "target/arm/cpu.h" > > > #include "qom/object.h" > > > #include "net/can_emu.h" > > > +#include "hw/dma/xlnx_csu_dma.h" > > > > > > #define TYPE_XLNX_ZYNQMP "xlnx,zynqmp" > > > OBJECT_DECLARE_SIMPLE_TYPE(XlnxZynqMPState, XLNX_ZYNQMP) > > > @@ -108,6 +109,7 @@ struct XlnxZynqMPState { > > > XlnxZynqMPRTC rtc; > > > XlnxZDMA gdma[XLNX_ZYNQMP_NUM_GDMA_CH]; > > > XlnxZDMA adma[XLNX_ZYNQMP_NUM_ADMA_CH]; > > > + XlnxCSUDMA qspi_dma; > > > > > > char *boot_cpu; > > > ARMCPU *boot_cpu_ptr; > > > diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c > > > index 49465a2794..30f43dfda2 100644 > > > --- a/hw/arm/xlnx-zynqmp.c > > > +++ b/hw/arm/xlnx-zynqmp.c > > > @@ -50,6 +50,7 @@ > > > #define QSPI_ADDR 0xff0f0000 > > > #define LQSPI_ADDR 0xc0000000 > > > #define QSPI_IRQ 15 > > > +#define QSPI_DMA_ADDR 0xff0f0800 > > > > > > #define DP_ADDR 0xfd4a0000 > > > #define DP_IRQ 113 > > > @@ -63,6 +64,8 @@ > > > #define RTC_ADDR 0xffa60000 > > > #define RTC_IRQ 26 > > > > > > + > > > + > > > > These blank lines look un-related, if you remove them, this looks good to me: > > > > Reviewed-by: Edgar E. Iglesias > > Thanks for the review. > > A RESEND version was already sent out to the ML before. Sorry for the > inconvenience. > http://patchwork.ozlabs.org/project/qemu-devel/patch/20210222131502.3098-4-bmeng.cn@gmail.com/ > Ah I see, no worries! Cheers, Edgar