From: "Alex Bennée" <alex.bennee@linaro.org>
To: peter.maydell@linaro.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
qemu-devel@nongnu.org, "Claudio Fontana" <cfontana@suse.de>
Subject: [PULL 7/7] docs: move CODING_STYLE into the developer documentation
Date: Wed, 24 Feb 2021 11:49:26 +0000 [thread overview]
Message-ID: <20210224114926.6303-8-alex.bennee@linaro.org> (raw)
In-Reply-To: <20210224114926.6303-1-alex.bennee@linaro.org>
There is no particular reason to keep this on it's own in the root of
the tree. Move it into the rest of the fine developer manual and fixup
any links to it. The only tweak I've made is to fix the code-block
annotations to mention the language C.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Claudio Fontana <cfontana@suse.de>
Message-Id: <20210223095931.16908-1-alex.bennee@linaro.org>
diff --git a/docs/devel/index.rst b/docs/devel/index.rst
index 22854e334d..ae664da00c 100644
--- a/docs/devel/index.rst
+++ b/docs/devel/index.rst
@@ -14,6 +14,7 @@ Contents:
:maxdepth: 2
build-system
+ style
kconfig
testing
fuzzing
diff --git a/CODING_STYLE.rst b/docs/devel/style.rst
similarity index 99%
rename from CODING_STYLE.rst
rename to docs/devel/style.rst
index 7bf4e39d48..8b0bdb3570 100644
--- a/CODING_STYLE.rst
+++ b/docs/devel/style.rst
@@ -641,7 +641,7 @@ trace-events style
In trace-events files, use a '0x' prefix to specify hex numbers, as in:
-.. code-block::
+.. code-block:: c
some_trace(unsigned x, uint64_t y) "x 0x%x y 0x" PRIx64
@@ -649,14 +649,14 @@ An exception is made for groups of numbers that are hexadecimal by
convention and separated by the symbols '.', '/', ':', or ' ' (such as
PCI bus id):
-.. code-block::
+.. code-block:: c
another_trace(int cssid, int ssid, int dev_num) "bus id: %x.%x.%04x"
However, you can use '0x' for such groups if you want. Anyway, be sure that
it is obvious that numbers are in hex, ex.:
-.. code-block::
+.. code-block:: c
data_dump(uint8_t c1, uint8_t c2, uint8_t c3) "bytes (in hex): %02x %02x %02x"
diff --git a/README.rst b/README.rst
index ce39d89077..91aa1e314c 100644
--- a/README.rst
+++ b/README.rst
@@ -66,7 +66,9 @@ When submitting patches, one common approach is to use 'git
format-patch' and/or 'git send-email' to format & send the mail to the
qemu-devel@nongnu.org mailing list. All patches submitted must contain
a 'Signed-off-by' line from the author. Patches should follow the
-guidelines set out in the CODING_STYLE.rst file.
+guidelines set out in the `style section
+<https://www.qemu.org/docs/master/devel/style.html>` of
+the Developers Guide.
Additional information on submitting patches can be found online via
the QEMU website
diff --git a/scripts/fix-multiline-comments.sh b/scripts/fix-multiline-comments.sh
index 93f9b10669..c15a041272 100755
--- a/scripts/fix-multiline-comments.sh
+++ b/scripts/fix-multiline-comments.sh
@@ -1,6 +1,6 @@
#! /bin/sh
#
-# Fix multiline comments to match CODING_STYLE
+# Fix multiline comments to match docs/devel/style.rst
#
# Copyright (C) 2018 Red Hat, Inc.
#
--
2.20.1
next prev parent reply other threads:[~2021-02-24 11:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-24 11:49 [PULL 0/7] testing updates (build, docs, dumps) Alex Bennée
2021-02-24 11:49 ` [PULL 1/7] meson.build: expose TCG cross compiler information in summary Alex Bennée
2021-02-24 11:49 ` [PULL 2/7] docker: Bump Fedora images to release 33 Alex Bennée
2021-02-24 11:49 ` [PULL 3/7] tests/acceptance: allow a "graceful" failing for virtio-gpu test Alex Bennée
2021-02-24 11:49 ` [PULL 4/7] docs/devel: expand on use of containers to build tests Alex Bennée
2021-02-24 11:49 ` [PULL 5/7] docs/devel: update the container based tests Alex Bennée
2021-02-24 11:49 ` [PULL 6/7] docs/devel: add forward reference to check-tcg Alex Bennée
2021-02-24 11:49 ` Alex Bennée [this message]
2021-03-02 15:17 ` [PULL 0/7] testing updates (build, docs, dumps) Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210224114926.6303-8-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=cfontana@suse.de \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).