From: "Alex Bennée" <alex.bennee@linaro.org>
To: richard.henderson@linaro.org
Cc: cota@braap.org, "Alex Bennée" <alex.bennee@linaro.org>,
qemu-devel@nongnu.org
Subject: [RFC PATCH 0/5] Experimenting with tb-lookup tweaks
Date: Wed, 24 Feb 2021 16:58:06 +0000 [thread overview]
Message-ID: <20210224165811.11567-1-alex.bennee@linaro.org> (raw)
Hi Richard,
Well I spun up some of the ideas we talked about to see if there was
anything to be squeezed out of the function. In the end the results
seem to be a washout with my pigz benchmark:
qemu-system-aarch64 -cpu cortex-a57 \
-machine type=virt,virtualization=on,gic-version=3 \
-serial mon:stdio \
-netdev user,id=unet,hostfwd=tcp::2222-:22 \
-device virtio-net-pci,netdev=unet,id=virt-net,disable-legacy=on \
-device virtio-scsi-pci,id=virt-scsi,disable-legacy=on \
-blockdev driver=raw,node-name=hd,discard=unmap,file.driver=host_device,file.filename=/dev/zen-disk/debian-buster-arm64 \
-device scsi-hd,drive=hd,id=virt-scsi-hd \
-smp 4 -m 4096 \
-kernel ~/lsrc/linux.git/builds/arm64/arch/arm64/boot/Image \
-append "root=/dev/sda2 systemd.unit=benchmark-pigz.service" \
-display none -snapshot
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---------+----------------+---------+---------+----------|
| Before | 46.597 ± 2.482 | 45.208 | 53.618 | 1.00 |
| After | 46.867 ± 2.242 | 45.871 | 53.180 | 1.00 |
Maybe the code cleanup itself makes it worthwhile. WDYT?
Alex Bennée (5):
accel/tcg: rename tb_lookup__cpu_state and hoist state extraction
accel/tcg: move CF_CLUSTER calculation to curr_cflags
accel/tcg: drop the use of CF_HASH_MASK and rename params
include/exec: lightly re-arrange TranslationBlock
include/exec/tb-lookup: try and reduce branch prediction issues
include/exec/exec-all.h | 20 +++++++++++---------
include/exec/tb-lookup.h | 34 +++++++++++++++++-----------------
accel/tcg/cpu-exec.c | 31 ++++++++++++++++++-------------
accel/tcg/tcg-runtime.c | 6 ++++--
accel/tcg/translate-all.c | 14 ++++++++------
softmmu/physmem.c | 2 +-
6 files changed, 59 insertions(+), 48 deletions(-)
--
2.20.1
next reply other threads:[~2021-02-24 17:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-24 16:58 Alex Bennée [this message]
2021-02-24 16:58 ` [RFC PATCH 1/5] accel/tcg: rename tb_lookup__cpu_state and hoist state extraction Alex Bennée
2021-02-24 16:58 ` [RFC PATCH 2/5] accel/tcg: move CF_CLUSTER calculation to curr_cflags Alex Bennée
2021-02-24 16:58 ` [RFC PATCH 3/5] accel/tcg: drop the use of CF_HASH_MASK and rename params Alex Bennée
2021-02-24 16:58 ` [RFC PATCH 4/5] include/exec: lightly re-arrange TranslationBlock Alex Bennée
2021-02-24 16:58 ` [RFC PATCH 5/5] include/exec/tb-lookup: try and reduce branch prediction issues Alex Bennée
2021-02-25 0:28 ` [RFC PATCH 0/5] Experimenting with tb-lookup tweaks Richard Henderson
2021-02-25 10:15 ` Alex Bennée
2021-02-25 15:45 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210224165811.11567-1-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=cota@braap.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).