From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: hare@suse.de
Subject: [PATCH 00/11] scsi-generic: error handling overhaul
Date: Wed, 24 Feb 2021 19:24:43 +0100 [thread overview]
Message-ID: <20210224182453.587731-1-pbonzini@redhat.com> (raw)
This series is mostly a refresh of Hannes's patches at
https://patchew.org/QEMU/20201116184041.60465-1-hare@suse.de/, which
haven't been applied yet because they broke the testsuite.
In addition to Hannes's introduction of host status in the SCSI
subsystem, which survives mostly in patches 3 and 6-10, I am also changing
scsi_handle_rw_error to always pass down guest-recoverable sense codes,
even if rerror=stop/werror=stop. Without this change, [rw]error=stop are
mostly unusable because the guest will stop even for unit attention sense.
Paolo
Supersedes: <20201116184041.60465-1-hare@suse.de>
Hannes Reinecke (5):
scsi: drop 'result' argument from command_complete callback
scsi: Rename linux-specific SG_ERR codes to generic SCSI_HOST error
codes
scsi: Add mapping for generic SCSI_HOST status to sense codes
scsi: inline sg_io_sense_from_errno() into the callers.
scsi: move host_status handling into SCSI drivers
Paolo Bonzini (5):
scsi-disk: move scsi_handle_rw_error earlier
scsi-disk: do not complete requests early for rerror/werror=ignore
scsi: introduce scsi_sense_from_errno()
scsi-disk: pass SCSI status to scsi_handle_rw_error
scsi-disk: pass guest recoverable errors through even for rerror=stop
hw/scsi/esp-pci.c | 5 +-
hw/scsi/esp.c | 7 +-
hw/scsi/lsi53c895a.c | 6 +-
hw/scsi/megasas.c | 6 +-
hw/scsi/mptsas.c | 5 +-
hw/scsi/scsi-bus.c | 23 ++++-
hw/scsi/scsi-disk.c | 203 ++++++++++++++++++++++-----------------
hw/scsi/scsi-generic.c | 20 ++--
hw/scsi/spapr_vscsi.c | 10 +-
hw/scsi/virtio-scsi.c | 51 +++++++++-
hw/scsi/vmw_pvscsi.c | 43 ++++++++-
hw/usb/dev-storage.c | 6 +-
hw/usb/dev-uas.c | 7 +-
include/hw/scsi/esp.h | 2 +-
include/hw/scsi/scsi.h | 6 +-
include/scsi/constants.h | 3 +
include/scsi/utils.h | 29 ++++--
scsi/qemu-pr-helper.c | 24 +++--
scsi/utils.c | 119 +++++++++++++++++------
19 files changed, 395 insertions(+), 180 deletions(-)
--
2.29.2
next reply other threads:[~2021-02-24 18:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-24 18:24 Paolo Bonzini [this message]
2021-02-24 18:24 ` [PATCH 01/10] scsi-disk: move scsi_handle_rw_error earlier Paolo Bonzini
2021-02-24 18:24 ` [PATCH 02/10] scsi-disk: do not complete requests early for rerror/werror=ignore Paolo Bonzini
2021-02-24 18:24 ` [PATCH 03/10] scsi: introduce scsi_sense_from_errno() Paolo Bonzini
2021-02-24 18:24 ` [PATCH 04/10] scsi-disk: pass SCSI status to scsi_handle_rw_error Paolo Bonzini
2021-02-24 18:24 ` [PATCH 05/10] scsi-disk: pass guest recoverable errors through even for rerror=stop Paolo Bonzini
2021-02-24 18:24 ` [PATCH 06/10] scsi: drop 'result' argument from command_complete callback Paolo Bonzini
2021-02-24 18:24 ` [PATCH 07/10] scsi: Rename linux-specific SG_ERR codes to generic SCSI_HOST error codes Paolo Bonzini
2021-02-24 18:24 ` [PATCH 08/10] scsi: Add mapping for generic SCSI_HOST status to sense codes Paolo Bonzini
2021-02-24 18:24 ` [PATCH 09/10] scsi: inline sg_io_sense_from_errno() into the callers Paolo Bonzini
2021-02-24 18:24 ` [PATCH 10/10] scsi: move host_status handling into SCSI drivers Paolo Bonzini
2021-02-24 19:05 ` [PATCH 00/11] scsi-generic: error handling overhaul Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210224182453.587731-1-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=hare@suse.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).