From: Eric Auger <eric.auger@redhat.com>
To: eric.auger.pro@gmail.com, eric.auger@redhat.com,
qemu-devel@nongnu.org, qemu-arm@nongnu.org,
peter.maydell@linaro.org, jean-philippe@linaro.org,
peterx@redhat.com, jasowang@redhat.com, pbonzini@redhat.com
Cc: vivek.gautam@arm.com, shameerali.kolothum.thodi@huawei.com
Subject: [PATCH v2 1/7] intel_iommu: Fix mask may be uninitialized in vtd_context_device_invalidate
Date: Thu, 25 Feb 2021 10:14:29 +0100 [thread overview]
Message-ID: <20210225091435.644762-2-eric.auger@redhat.com> (raw)
In-Reply-To: <20210225091435.644762-1-eric.auger@redhat.com>
With -Werror=maybe-uninitialized configuration we get
../hw/i386/intel_iommu.c: In function ‘vtd_context_device_invalidate’:
../hw/i386/intel_iommu.c:1888:10: error: ‘mask’ may be used
uninitialized in this function [-Werror=maybe-uninitialized]
1888 | mask = ~mask;
| ~~~~~^~~~~~~
Add a g_assert_not_reached() to avoid the error.
Signed-off-by: Eric Auger <eric.auger@redhat.com>
---
hw/i386/intel_iommu.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
index b4f5094259..3206f379f8 100644
--- a/hw/i386/intel_iommu.c
+++ b/hw/i386/intel_iommu.c
@@ -1884,6 +1884,8 @@ static void vtd_context_device_invalidate(IntelIOMMUState *s,
case 3:
mask = 7; /* Mask bit 2:0 in the SID field */
break;
+ default:
+ g_assert_not_reached();
}
mask = ~mask;
--
2.26.2
next prev parent reply other threads:[~2021-02-25 9:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-25 9:14 [PATCH v2 0/7] Some vIOMMU fixes Eric Auger
2021-02-25 9:14 ` Eric Auger [this message]
2021-02-25 10:08 ` [PATCH v2 1/7] intel_iommu: Fix mask may be uninitialized in vtd_context_device_invalidate Philippe Mathieu-Daudé
2021-02-25 16:33 ` Auger Eric
2021-02-25 15:41 ` Peter Xu
2021-02-25 9:14 ` [PATCH v2 2/7] dma: Introduce dma_aligned_pow2_mask() Eric Auger
2021-02-25 15:56 ` Peter Xu
2021-03-08 16:34 ` Peter Maydell
2021-02-25 9:14 ` [PATCH v2 3/7] virtio-iommu: Handle non power of 2 range invalidations Eric Auger
2021-02-25 16:01 ` Peter Xu
2021-02-25 9:14 ` [PATCH v2 4/7] hw/arm/smmu-common: Fix smmu_iotlb_inv_iova when asid is not set Eric Auger
2021-03-08 16:37 ` Peter Maydell
2021-03-09 8:37 ` Auger Eric
2021-02-25 9:14 ` [PATCH v2 5/7] hw/arm/smmuv3: Enforce invalidation on a power of two range Eric Auger
2021-03-08 16:44 ` Peter Maydell
2021-02-25 9:14 ` [PATCH v2 6/7] hw/arm/smmuv3: Fix SMMU_CMD_CFGI_STE_RANGE handling Eric Auger
2021-03-08 16:41 ` Peter Maydell
2021-02-25 9:14 ` [PATCH v2 7/7] hw/arm/smmuv3: Uniformize sid traces Eric Auger
2021-02-25 10:11 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210225091435.644762-2-eric.auger@redhat.com \
--to=eric.auger@redhat.com \
--cc=eric.auger.pro@gmail.com \
--cc=jasowang@redhat.com \
--cc=jean-philippe@linaro.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=vivek.gautam@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).