From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2484EC433E0 for ; Thu, 25 Feb 2021 15:26:52 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5A16464F18 for ; Thu, 25 Feb 2021 15:26:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5A16464F18 Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=nongnu.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47182 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lFIXS-0004DL-C5 for qemu-devel@archiver.kernel.org; Thu, 25 Feb 2021 10:26:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46802) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lFIVg-0002XA-8f for qemu-devel@nongnu.org; Thu, 25 Feb 2021 10:25:00 -0500 Received: from rev.ng ([5.9.113.41]:35751) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lFIVe-0003PT-Pa for qemu-devel@nongnu.org; Thu, 25 Feb 2021 10:25:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=rev.ng; s=dkim; h=Content-Transfer-Encoding:Content-Type:MIME-Version:References: In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Jquf2iJW5jTdpV/+AfwurIUv+cTL14UOQMCpqJiCpwA=; b=mVuxcQsQt4RyIruTxDO+DF7n8K lS6AadaSCI7hjBFhvqQL4FKlP4NPKMfZxvN0XBJb0OhY0B9KrIdo3X53soOOJnhAHaAZFYQd3MZna /BOynZm6ghI402B2gjSvaIDEdY6YL6U5Ut+qoTsKR3yZ/ZP4oUt8mXjXfqN6UBusQx+0=; Date: Thu, 25 Feb 2021 16:24:48 +0100 To: Richard Henderson Cc: Alessandro Di Federico , qemu-devel@nongnu.org, babush@rev.ng, bcain@quicinc.com, tsimpson@quicinc.com, nizzo@rev.ng Subject: Re: [RFC PATCH 00/10] target/hexagon: introduce idef-parser Message-ID: <20210225162448.32061a7b@orange> In-Reply-To: <517570b3-2e0f-3f3e-697b-5fa61754ba7e@linaro.org> References: <20210211215051.2102435-1-ale.qemu@rev.ng> <517570b3-2e0f-3f3e-697b-5fa61754ba7e@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=5.9.113.41; envelope-from=ale@rev.ng; helo=rev.ng X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Reply-to: Alessandro Di Federico From: Alessandro Di Federico via On Sun, 14 Feb 2021 13:52:25 -0800 Richard Henderson wrote: > Well, first off, this fails to build with our gitlab CI. > > There are several problems, apart from the new bison parse.error > option previously reported: > > (1) bison and flex not added to dockerfiles, so the packages are not > available to CI. > > (2) idef-parser program not marked with "native: true", so we get an > early meson error about that. > > (3) flex = generator() does not specify both output files, so the > proper dependency on idef-parser.yy.h is not present. > > (4) idef-parser.yy.h is placed in the wrong directory, because you > used '%option header-file="xyz"' instead of the command-line > '--headerfile=@OUTPUT1@'. This results in an immediate compilation > failure, because the file isn't found. > > (5) There's an odd mismatch in file naming, in which you have > idef-lexer.lex.yy.c but idef-parser.yy.h. Not a bug, really, but it > looks odd when fixing 3 & 4. We've integrated the suggested changes and tested the v2 on the Gitlab CI. It should now work properly. -- Alessandro Di Federico rev.ng