Re: QEMU CI failed due to canceled download

[Cleber Rosa <crosa@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1173 bytes --]

On Thu, Feb 25, 2021 at 05:51:08AM +0100, Thomas Huth wrote:
> 
>  Hi,
> 
> I just faced this failure in the CI:
> 
>  https://gitlab.com/thuth/qemu/-/jobs/1053467007#L73
> 
> I thought we'd handle CANCEL as "skipped"? Why did this
> cause the CI to fail?
>

Hi Thomas,

Like Wainer pointed out, your expectations are correct.  CANCEL behaves
like a skip, but because the test was underway, rather than never
tried, Avocado calls it that way.

So, in this particular case, the test was actually interrupted, and it
was interrupted while downloading the Fedora 31 image, which it
*shouldn't* be doing during the test.  The "get-vm-images" target
defined in tests/Makefile.include is a prerequisite for
"check-acceptance", so that those files get downloaded before the
Avocado job even starts.

It looks like that on c401c058a1c a TARGETS variable was introduced
with a different format than it was coming from the main Makefile.
And, IIUC, that made the "get-vm-images" succeed because there was
no matching architecture to download.

I've reproduced the issue on my system, and I'm sending a patch with
a proposed fix.

Thanks,
- Cleber.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]