* [PATCH] net: Fix build error when DEBUG_NET is on
@ 2021-02-28 5:02 Bin Meng
2021-03-02 9:09 ` Jason Wang
0 siblings, 1 reply; 4+ messages in thread
From: Bin Meng @ 2021-02-28 5:02 UTC (permalink / raw)
To: Jason Wang, qemu-devel; +Cc: Bin Meng, Philippe Mathieu-Daudé
From: Bin Meng <bin.meng@windriver.com>
"qemu-common.h" should be included to provide the forward declaration
of qemu_hexdump() when DEBUG_NET is on.
Signed-off-by: Bin Meng <bin.meng@windriver.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
Changes in v2:
- add "Reviewed-By" tag
net/net.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/net.c b/net/net.c
index fb7b7dcc25..32d71c1172 100644
--- a/net/net.c
+++ b/net/net.c
@@ -23,6 +23,7 @@
*/
#include "qemu/osdep.h"
+#include "qemu-common.h"
#include "net/net.h"
#include "clients.h"
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] net: Fix build error when DEBUG_NET is on
2021-02-28 5:02 [PATCH] net: Fix build error when DEBUG_NET is on Bin Meng
@ 2021-03-02 9:09 ` Jason Wang
0 siblings, 0 replies; 4+ messages in thread
From: Jason Wang @ 2021-03-02 9:09 UTC (permalink / raw)
To: Bin Meng, qemu-devel; +Cc: Bin Meng, Philippe Mathieu-Daudé
On 2021/2/28 1:02 下午, Bin Meng wrote:
> From: Bin Meng <bin.meng@windriver.com>
>
> "qemu-common.h" should be included to provide the forward declaration
> of qemu_hexdump() when DEBUG_NET is on.
>
> Signed-off-by: Bin Meng <bin.meng@windriver.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Applied.
Thanks
>
> ---
>
> Changes in v2:
> - add "Reviewed-By" tag
>
> net/net.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/net.c b/net/net.c
> index fb7b7dcc25..32d71c1172 100644
> --- a/net/net.c
> +++ b/net/net.c
> @@ -23,6 +23,7 @@
> */
>
> #include "qemu/osdep.h"
> +#include "qemu-common.h"
>
> #include "net/net.h"
> #include "clients.h"
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] net: Fix build error when DEBUG_NET is on
@ 2021-02-26 7:56 Bin Meng
2021-02-26 9:03 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 4+ messages in thread
From: Bin Meng @ 2021-02-26 7:56 UTC (permalink / raw)
To: Jason Wang, qemu-devel; +Cc: Bin Meng
From: Bin Meng <bin.meng@windriver.com>
"qemu-common.h" should be included to provide the forward declaration
of qemu_hexdump() when DEBUG_NET is on.
Signed-off-by: Bin Meng <bin.meng@windriver.com>
---
net/net.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/net.c b/net/net.c
index fb7b7dc..32d71c1 100644
--- a/net/net.c
+++ b/net/net.c
@@ -23,6 +23,7 @@
*/
#include "qemu/osdep.h"
+#include "qemu-common.h"
#include "net/net.h"
#include "clients.h"
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] net: Fix build error when DEBUG_NET is on
2021-02-26 7:56 Bin Meng
@ 2021-02-26 9:03 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-02-26 9:03 UTC (permalink / raw)
To: Bin Meng, Jason Wang, qemu-devel; +Cc: Bin Meng
On 2/26/21 8:56 AM, Bin Meng wrote:
> From: Bin Meng <bin.meng@windriver.com>
>
> "qemu-common.h" should be included to provide the forward declaration
> of qemu_hexdump() when DEBUG_NET is on.
>
> Signed-off-by: Bin Meng <bin.meng@windriver.com>
> ---
>
> net/net.c | 1 +
> 1 file changed, 1 insertion(+)
Similarly:
- hw/net/fsl_etsec/etsec.c
- hw/net/fsl_etsec/rings.c
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-03-02 9:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-28 5:02 [PATCH] net: Fix build error when DEBUG_NET is on Bin Meng
2021-03-02 9:09 ` Jason Wang
-- strict thread matches above, loose matches on Subject: below --
2021-02-26 7:56 Bin Meng
2021-02-26 9:03 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).