* [PATCH] hw/net: fsl_etsec: Fix build error when HEX_DUMP is on
@ 2021-02-28 5:04 Bin Meng
2021-02-28 6:32 ` David Gibson
0 siblings, 1 reply; 2+ messages in thread
From: Bin Meng @ 2021-02-28 5:04 UTC (permalink / raw)
To: David Gibson, Greg Kurz, Jason Wang
Cc: Philippe Mathieu-Daudé, Bin Meng, qemu-ppc, qemu-devel
From: Bin Meng <bin.meng@windriver.com>
"qemu-common.h" should be included to provide the forward declaration
of qemu_hexdump() when HEX_DUMP is on.
Signed-off-by: Bin Meng <bin.meng@windriver.com>
---
hw/net/fsl_etsec/etsec.c | 1 +
hw/net/fsl_etsec/rings.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/hw/net/fsl_etsec/etsec.c b/hw/net/fsl_etsec/etsec.c
index 93886bba60..bd9d62b559 100644
--- a/hw/net/fsl_etsec/etsec.c
+++ b/hw/net/fsl_etsec/etsec.c
@@ -27,6 +27,7 @@
*/
#include "qemu/osdep.h"
+#include "qemu-common.h"
#include "hw/sysbus.h"
#include "hw/irq.h"
#include "hw/ptimer.h"
diff --git a/hw/net/fsl_etsec/rings.c b/hw/net/fsl_etsec/rings.c
index fe055d3381..d6be0d7d18 100644
--- a/hw/net/fsl_etsec/rings.c
+++ b/hw/net/fsl_etsec/rings.c
@@ -22,6 +22,7 @@
* THE SOFTWARE.
*/
#include "qemu/osdep.h"
+#include "qemu-common.h"
#include "net/checksum.h"
#include "qemu/log.h"
#include "etsec.h"
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hw/net: fsl_etsec: Fix build error when HEX_DUMP is on
2021-02-28 5:04 [PATCH] hw/net: fsl_etsec: Fix build error when HEX_DUMP is on Bin Meng
@ 2021-02-28 6:32 ` David Gibson
0 siblings, 0 replies; 2+ messages in thread
From: David Gibson @ 2021-02-28 6:32 UTC (permalink / raw)
To: Bin Meng
Cc: Jason Wang, Bin Meng, Greg Kurz, qemu-devel, qemu-ppc,
Philippe Mathieu-Daudé
[-- Attachment #1: Type: text/plain, Size: 1337 bytes --]
On Sun, Feb 28, 2021 at 01:04:31PM +0800, Bin Meng wrote:
> From: Bin Meng <bin.meng@windriver.com>
>
> "qemu-common.h" should be included to provide the forward declaration
> of qemu_hexdump() when HEX_DUMP is on.
Applied to ppc-for-6.0, thanks.
>
> Signed-off-by: Bin Meng <bin.meng@windriver.com>
> ---
>
> hw/net/fsl_etsec/etsec.c | 1 +
> hw/net/fsl_etsec/rings.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/hw/net/fsl_etsec/etsec.c b/hw/net/fsl_etsec/etsec.c
> index 93886bba60..bd9d62b559 100644
> --- a/hw/net/fsl_etsec/etsec.c
> +++ b/hw/net/fsl_etsec/etsec.c
> @@ -27,6 +27,7 @@
> */
>
> #include "qemu/osdep.h"
> +#include "qemu-common.h"
> #include "hw/sysbus.h"
> #include "hw/irq.h"
> #include "hw/ptimer.h"
> diff --git a/hw/net/fsl_etsec/rings.c b/hw/net/fsl_etsec/rings.c
> index fe055d3381..d6be0d7d18 100644
> --- a/hw/net/fsl_etsec/rings.c
> +++ b/hw/net/fsl_etsec/rings.c
> @@ -22,6 +22,7 @@
> * THE SOFTWARE.
> */
> #include "qemu/osdep.h"
> +#include "qemu-common.h"
> #include "net/checksum.h"
> #include "qemu/log.h"
> #include "etsec.h"
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-28 6:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-28 5:04 [PATCH] hw/net: fsl_etsec: Fix build error when HEX_DUMP is on Bin Meng
2021-02-28 6:32 ` David Gibson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).