From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29EF7C433DB for ; Mon, 1 Mar 2021 11:29:07 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AF4C560238 for ; Mon, 1 Mar 2021 11:29:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AF4C560238 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56410 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lGgjZ-0001JM-LR for qemu-devel@archiver.kernel.org; Mon, 01 Mar 2021 06:29:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56726) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lGghZ-00087M-7T for qemu-devel@nongnu.org; Mon, 01 Mar 2021 06:27:01 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:52129) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lGghX-0007qx-SR for qemu-devel@nongnu.org; Mon, 01 Mar 2021 06:27:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614598019; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yXOLbxmWRCv04n8YDpJqk53QLgbu+SGhu72P0vyw1wk=; b=dZu2yChQdEOvKr5wvad8KXrXa3D+/LB/gFoGBL2V0CPH6EX1ofMQSA348AFeJZXDDvkBJf YjuA3sPI6Q+xEH+wewy0JM9NyeWlJ+ql2P23FBMk3hdW4JItdLV3DSlrB4GFSYIXCwyLVa 24jYqhDjQLgdVIvBG3rsaVaYbGuAk2M= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-581-BWxYdJtvNzKkAAbITxm6rQ-1; Mon, 01 Mar 2021 06:26:55 -0500 X-MC-Unique: BWxYdJtvNzKkAAbITxm6rQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A3CE3107ACC7; Mon, 1 Mar 2021 11:26:54 +0000 (UTC) Received: from merkur.fritz.box (ovpn-114-165.ams2.redhat.com [10.36.114.165]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 625FA60BFA; Mon, 1 Mar 2021 11:26:53 +0000 (UTC) Date: Mon, 1 Mar 2021 12:26:51 +0100 From: Kevin Wolf To: Stefano Garzarella Subject: Re: [PATCH v2] blockjob: report a better error message Message-ID: <20210301112651.GE7698@merkur.fritz.box> References: <20210225103633.76746-1-sgarzare@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210225103633.76746-1-sgarzare@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kwolf@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.248, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vladimir Sementsov-Ogievskiy , John Snow , qemu-devel@nongnu.org, qemu-block@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Am 25.02.2021 um 11:36 hat Stefano Garzarella geschrieben: > When a block job fails, we report strerror(-job->job.ret) error > message, also if the job set an error object. > Let's report a better error message using error_get_pretty(job->job.err). > > If an error object was not set, strerror(-job->ret) is used as fallback, > as explained in include/qemu/job.h: > > typedef struct Job { > ... > /** > * Error object for a failed job. > * If job->ret is nonzero and an error object was not set, it will be set > * to strerror(-job->ret) during job_completed. > */ > Error *err; > } > > In block_job_query() there can be a transient where 'job.err' is not set > by a scheduled bottom half. In that case we use strerror(-job->ret) as it > was before. > > Suggested-by: Kevin Wolf > Signed-off-by: Stefano Garzarella Thanks, applied to the block branch. Kevin